[some help required] Add bash completions #542
Conversation
Closes: mquinson#417 Signed-off-by: Alexander Golubev <[email protected]>
|
Can Getopt::Long::Complete (or alternatives) be used to support shell completion? (I haven't tried yet though) |
|
@gemmaro It would resolve the issue with speed, but I'm a bit hesitant of introducing the dependency. If we make it required, it would be somewhat annoying for people who don't need it, and if we make it optional, it'd be either impossible to keep trek of it from the bash's side or nontrivial for maintainers to install. Maybe instead we can add a flag that will just list the flags without help? |
Adding an optional completion package sounds like a good idea.
I like the way the completion script has granular control (e.g. |
To be fair, I don't know about perl infrastructure enough to make this call neither it's my call to make anyway.
The problem with this is that you will have to have a bash_completion file around anyway. And how to communicate to the maintainer whether the file is needed? If we just won't install it, the opportunity for completion will be unnoticeable for end-users. If we install it, there will be a problem that if the Getopt::Long::Complete is absent and a user tries to complete something it will result in an incorrect call... I'm not sure how to resolve all this in a sane-ish manner...
You mean po4a's modules' options? Unfortunately as for now it won't be trivial as there are no way to query a module which options it supports. |
I've sketched some bash completions. Nothing extra fancy just command-line options and some a couple of options with predefined values.
To test you may
export BASH_COMPLETION_USER_DIR=/path/to/po4a/share/bash-completion/and then play withpo4a -<TAB><TAB>etc.Note that the completions are using
<script> --help, and since po4a has to process PODs to print it, the completions are lagging a bit (~200ms, not absolutely infuriating, but still noticeable and slightly annoying).But I need some help with installation scripting, I have very little idea how to do it with perl. The files in
share/bash-completion/completionsare supposed to be installed to directory pointed bypkg-config --variable=completionsdir bash-completion. Usually it's/usr/share/bash-completion/completions.PS: Also the commit contains several symlinks. I'm not sure if it's ok to store those in the sources. If not, those should be also created during build.
Closes: #417