Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: Is there any idea to improve groot? #15

Open
mr54ndm4n opened this issue Oct 4, 2018 · 2 comments
Open

Discussion: Is there any idea to improve groot? #15

mr54ndm4n opened this issue Oct 4, 2018 · 2 comments

Comments

@mr54ndm4n
Copy link
Owner

mr54ndm4n commented Oct 4, 2018

Can be any features, design, etc.
so we can create a new issues :)

@mr54ndm4n mr54ndm4n changed the title Discussion Discussion: Is there any idea to improve groot? Oct 4, 2018
@avivbiton
Copy link

I'd say refactoring is really needed, naming and break code into smaller methods, it's hard to understand what each method does ( For me at least)

@avivbiton
Copy link

From looking more at the code, what I feel that is missing:
Error handling, what happens when the Csv File is invalid?
Should the program throw an exception with the invalid line number or just skip the line?
A configuration file should be used for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants