-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(form): radio input with radio group component #45
Open
erfanmoghadasi
wants to merge
4
commits into
main
Choose a base branch
from
feat(form)/radio-44
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
944db6b
feat(form): radio input with radio group component
erfanmoghadasi 587bca9
Merge branch 'main' of https://github.com/mrbadri/mui-builder into fe…
erfanmoghadasi 2a1974d
Merge branch 'main' of https://github.com/mrbadri/mui-builder into fe…
erfanmoghadasi 6518310
feat(form): use option type in public.types as radioInputs list
erfanmoghadasi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
packages/core/src/modules/form/src/components/fields/radio/radio.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
import { FC } from 'react'; | ||
|
||
import { FormControlLabel, Radio as MuiRadio } from '@mui/material'; | ||
|
||
import { RadioProps } from './radio.types'; | ||
|
||
import useRadio from './useRadio'; | ||
|
||
const Radio: FC<RadioProps> = (props) => { | ||
const { getFormControlLabelProps, getRadioInputProps } = useRadio(props); | ||
|
||
return ( | ||
<FormControlLabel | ||
{...getFormControlLabelProps()} | ||
control={<MuiRadio {...getRadioInputProps()} />} | ||
/> | ||
); | ||
}; | ||
|
||
export default Radio; |
28 changes: 28 additions & 0 deletions
28
packages/core/src/modules/form/src/components/fields/radio/radio.types.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
import { | ||
FormControlLabelProps, | ||
RadioGroupProps as MuiRadioGroupProps, | ||
RadioProps as MuiRadioProps, | ||
} from '@mui/material'; | ||
|
||
import { Api } from '@mui-builder/types/api.types'; | ||
import { Script } from '@mui-builder/types/script.types'; | ||
|
||
import { Dependencies, FormId, Id, Option } from '../../../types/public.types'; | ||
import { Rule } from '../../../types/validation.types'; | ||
|
||
export type RadioProps = Omit<FormControlLabelProps, 'control' | 'label'> & | ||
Option & { | ||
radioInputProps?: MuiRadioProps; | ||
}; | ||
|
||
export type RadioGroupProps = MuiRadioGroupProps & { | ||
id: Id; | ||
formId: FormId; | ||
script?: Script; | ||
dependesies?: Dependencies; | ||
propsController?: Record<string, any>; | ||
api?: Api; | ||
rule?: Rule; | ||
show?: boolean; | ||
options: RadioProps[]; | ||
}; |
22 changes: 22 additions & 0 deletions
22
packages/core/src/modules/form/src/components/fields/radio/radioGroup.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
import { FC } from 'react'; | ||
|
||
import { RadioGroup as MuiRadioGroup } from '@mui/material'; | ||
|
||
import { RadioGroupProps } from './radio.types'; | ||
|
||
import Radio from './radio'; | ||
import useRadioGroup from './useRadioGroup'; | ||
|
||
const RadioGroup: FC<RadioGroupProps> = (props) => { | ||
const { getRadioGroupProps, options } = useRadioGroup(props); | ||
|
||
return ( | ||
<MuiRadioGroup {...getRadioGroupProps()}> | ||
{options.map((radio) => ( | ||
<Radio key={radio.id} {...radio} /> | ||
))} | ||
</MuiRadioGroup> | ||
); | ||
}; | ||
|
||
export default RadioGroup; |
13 changes: 13 additions & 0 deletions
13
packages/core/src/modules/form/src/components/fields/radio/useRadio.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
import { RadioProps } from './radio.types'; | ||
|
||
const useRadio = (props: RadioProps) => { | ||
const { radioInputProps, ...restRadioProps } = props; | ||
|
||
const getRadioInputProps = () => ({ ...radioInputProps }); | ||
|
||
const getFormControlLabelProps = () => ({ ...restRadioProps, label: restRadioProps.name }); | ||
|
||
return { getRadioInputProps, getFormControlLabelProps }; | ||
}; | ||
|
||
export default useRadio; |
84 changes: 84 additions & 0 deletions
84
packages/core/src/modules/form/src/components/fields/radio/useRadioGroup.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,84 @@ | ||
import { useController, useWatch } from 'react-hook-form'; | ||
|
||
import useQueryBuilder from '@mui-builder/utils/useQueryBuilder/useQueryBuilder'; | ||
import UseScript from '@mui-builder/utils/useScript/useScript'; | ||
|
||
import axios from 'axios'; | ||
|
||
import { RadioGroupProps } from './radio.types'; | ||
|
||
import useForms from '../../../hooks/useForms/useForms'; | ||
import usePropsController from '../../../hooks/usePropsController/usePropsController'; | ||
import useRule from '../../../hooks/useRule/useRule'; | ||
|
||
const useRadioGroup = (props: RadioGroupProps) => { | ||
const { | ||
id, | ||
api, | ||
script, | ||
formId, | ||
show = true, | ||
dependesies, | ||
defaultValue, | ||
options, | ||
...restRadioGroupProps | ||
} = props; | ||
|
||
const { configs, queries } = api || {}; | ||
|
||
const { forms } = useForms(); | ||
const formMethod = forms?.[formId]; | ||
|
||
const { setProps, propsController } = usePropsController(); | ||
const newProps = propsController?.[id] || {}; | ||
|
||
useQueryBuilder({ | ||
apiInstance: axios, | ||
apiConfigs: configs ?? {}, | ||
apiQuery: queries ?? {}, | ||
formMethod, | ||
formId, | ||
forms, | ||
}); | ||
|
||
// Handle Wtach Fields | ||
useWatch({ | ||
control: formMethod.control, | ||
name: dependesies ?? [], | ||
}); | ||
|
||
// Controller | ||
const { | ||
field, | ||
formState: { errors }, | ||
} = useController({ | ||
name: id, | ||
control: formMethod.control, | ||
// disabled: restRadioGroupProps.disabled, | ||
rules: useRule(restRadioGroupProps?.rule), | ||
defaultValue, | ||
}); | ||
|
||
const error = errors?.[id]; | ||
|
||
// Handle Script | ||
const { scriptResult } = UseScript({ | ||
script, | ||
formMethod, | ||
forms, | ||
formId, | ||
setProps, | ||
}); | ||
|
||
const getRadioGroupProps = () => ({ | ||
...field, | ||
...restRadioGroupProps, | ||
error, | ||
...scriptResult, | ||
...newProps, | ||
}); | ||
|
||
return { getRadioGroupProps, options }; | ||
}; | ||
|
||
export default useRadioGroup; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The implementation for the 'radio' case in the switch statement follows the established pattern and correctly uses lazy loading and suspense. Consider using a more specific loading component for radio fields, similar to other field types, to enhance user experience.
Committable suggestion