Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): hls.cmd validation fails on list with one element #412

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

samtay
Copy link
Contributor

@samtay samtay commented Oct 22, 2024

I noticed if I specify cmd = { "static-ls" } I get this empty list error.

Copy link
Contributor

Review Checklist

Does this PR follow the Contribution Guidelines? Following is a partial checklist:

Proper conventional commit scoping:

  • For example, fix(lsp): some lsp-related bugfix

  • Pull request title has the appropriate conventional commit prefix.

If applicable:

  • Tested
    • Tests have been added.
    • Tested manually (Steps to reproduce in PR description).
  • Updated documentation.

@mrcjkb mrcjkb changed the title Fix checking for empty list fix: hls.cmd validation fails on list with one element Oct 22, 2024
@mrcjkb mrcjkb changed the title fix: hls.cmd validation fails on list with one element fix(config): hls.cmd validation fails on list with one element Oct 22, 2024
Copy link
Owner

@mrcjkb mrcjkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@mrcjkb mrcjkb enabled auto-merge (squash) October 22, 2024 04:27
@mrcjkb mrcjkb merged commit 37a2881 into mrcjkb:master Oct 22, 2024
6 checks passed
mrcjkb added a commit that referenced this pull request Oct 22, 2024
🤖 I have created a release *beep* *boop*
---


##
[4.3.1](v4.3.0...v4.3.1)
(2024-10-22)


### Bug Fixes

* **config:** `hls.cmd` validation fails on list with one element
([#412](#412))
([37a2881](37a2881))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants