Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Just a Question: Why did you use an array to store your Service Mapping ? #9

Closed
tom-biebl opened this issue Aug 7, 2023 · 2 comments

Comments

@tom-biebl
Copy link

Hello there,

I took a look at your source code and wondered, why you use an array to store the service-mapping instead of an Map ?

That's not a condemnation, I'm just wondering.
I am looking forward to hear from you.

Tom

@mrcwbr
Copy link
Owner

mrcwbr commented Aug 8, 2023

hey nice hint. I just create a PR where I change the implementation to an object. it should also increase the performance of the service container: #10 if you like the code, I'll close the PR and publish a new release.

@tom-biebl
Copy link
Author

Yeah looks nice, i am looking forward to check out the new performance :)

Have a great day mate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants