Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Models loaded in Three.js 155dev are dark #26410

Closed
andreasrosdal opened this issue Jul 11, 2023 · 3 comments
Closed

Models loaded in Three.js 155dev are dark #26410

andreasrosdal opened this issue Jul 11, 2023 · 3 comments

Comments

@andreasrosdal
Copy link
Contributor

Description

The models loaded in Three.js 155dev are dark. They are loaded using the GLTFLoader.
Using Three.js r154 the models had correctly lighting.

Is there some API change in this build that I need to update the code using Three.js?

Reproduction steps

  1. Build Fciv.net using Three.js 155dev.
  2. Start a new game.
  3. Observe darkness.

Code

https://github.com/fciv-net/fciv-net

Live example

https://github.com/fciv-net/fciv-net

Screenshots

Screenshot_20230711_182704

Version

r155dev

Device

No response

Browser

No response

OS

No response

@Mugen87
Copy link
Collaborator

Mugen87 commented Jul 11, 2023

Can you please verify if you are affected by #26392?

More detailed explanation: https://discourse.threejs.org/t/updates-to-lighting-in-three-js-r155/53733

@andreasrosdal
Copy link
Contributor Author

Yes, I am affected by #26392

Further, I am using

THREE.ColorManagement.enabled = false;

here: https://github.com/fciv-net/fciv-net/blob/main/freeciv-web/src/main/webapp/javascript/webgl/mapview.js#L69
in order to opt-out of using the new colour model in r152 (described in #25917 where the objects were too bright).

I am interested in doing the correct migrations in order to use Three.js correctly and get as good colours as possible.

Further, I hope to be a good early adopter and tester of new features in Three.js.

@Mugen87
Copy link
Collaborator

Mugen87 commented Jul 11, 2023

In this case please use the forum if you encounter issues with color management or lighting. There are dedicated topics for both changes. Please files only issues at GitHub if you encounter bugs or have feature requests.

@Mugen87 Mugen87 closed this as completed Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants