Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Discord Webhook messaging async #12

Closed
mrghosti3 opened this issue Aug 3, 2023 · 0 comments · Fixed by #13
Closed

Make Discord Webhook messaging async #12

mrghosti3 opened this issue Aug 3, 2023 · 0 comments · Fixed by #13
Assignees
@mrghosti3
Labels
enhancement New feature or request
Milestone
v0.3.1

Comments

@mrghosti3
Copy link
Owner

Since plugin code (especially Even handling) is run on a single main thread, it might increase performance while sending messages. This is because there can be micro stutters or some lag on server when sending messages to web hook.
@mrghosti3 mrghosti3 added the enhancement New feature or request label Aug 3, 2023
@mrghosti3 mrghosti3 self-assigned this Aug 3, 2023
@mrghosti3 mrghosti3 added this to the v0.3.1 milestone Aug 3, 2023
@mrghosti3 mrghosti3 mentioned this issue Aug 5, 2023
Merged
@mrghosti3 mrghosti3 linked a pull request Aug 5, 2023 that will close this issue
Send Discord player messages asynchronously #13
Merged
mrghosti3 added a commit that referenced this issue Aug 5, 2023
@mrghosti3
Merge pull request #13 from mrghosti3/12-async-discord
445cbd9 
Send Discord player messages asynchronously

Closes #12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrghosti3 mrghosti3

Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.3.1
Development

Successfully merging a pull request may close this issue.

Send Discord player messages asynchronously mrghosti3/CustomPlugin
1 participant
@mrghosti3