Skip to content

Commit 8a0a5c1

Browse files
committed
Issue #2392153 by mparker17, hussainweb, chris.smith, alexpott, dawehner: Disallow composer.json and composer.lock from being indexed
(cherry picked from commit 580b4cf09ab4448d71ac35dffb803d5550ef4786)
1 parent b422873 commit 8a0a5c1

File tree

5 files changed

+7
-2
lines changed

5 files changed

+7
-2
lines changed

.htaccess

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
#
44

55
# Protect files and directories from prying eyes.
6-
<FilesMatch "\.(engine|inc|install|make|module|profile|po|sh|.*sql|theme|twig|tpl(\.php)?|xtmpl|yml)(~|\.sw[op]|\.bak|\.orig|\.save)?$|^(\..*|Entries.*|Repository|Root|Tag|Template)$|^#.*#$|\.php(~|\.sw[op]|\.bak|\.orig|\.save)$">
6+
<FilesMatch "\.(engine|inc|install|make|module|profile|po|sh|.*sql|theme|twig|tpl(\.php)?|xtmpl|yml)(~|\.sw[op]|\.bak|\.orig|\.save)?$|^(\..*|Entries.*|Repository|Root|Tag|Template|composer\.(json|lock))$|^#.*#$|\.php(~|\.sw[op]|\.bak|\.orig|\.save)$">
77
<IfModule mod_authz_core.c>
88
Require all denied
99
</IfModule>

core/modules/system/src/Tests/System/HtaccessTest.php

+5
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,11 @@ protected function getProtectedFiles() {
8686
foreach ($file_exts_to_allow as $file_ext) {
8787
$file_paths["$path/access_test.$file_ext"] = 200;
8888
}
89+
90+
// Ensure composer.json and composer.lock cannot be accessed.
91+
$file_paths["$path/composer.json"] = 403;
92+
$file_paths["$path/composer.lock"] = 403;
93+
8994
return $file_paths;
9095
}
9196

core/modules/system/tests/fixtures/HtaccessTest/composer.json

Whitespace-only changes.

core/modules/system/tests/fixtures/HtaccessTest/composer.lock

Whitespace-only changes.

web.config

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
<rewrite>
2323
<rules>
2424
<rule name="Protect files and directories from prying eyes" stopProcessing="true">
25-
<match url="\.(engine|inc|install|module|profile|po|sh|.*sql|theme|twig|tpl(\.php)?|xtmpl|yml|svn-base)$|^(code-style\.pl|Entries.*|Repository|Root|Tag|Template|all-wcprops|entries|format)$" />
25+
<match url="\.(engine|inc|install|module|profile|po|sh|.*sql|theme|twig|tpl(\.php)?|xtmpl|yml|svn-base)$|^(code-style\.pl|Entries.*|Repository|Root|Tag|Template|all-wcprops|entries|format|composer\.(json|lock))$" />
2626
<action type="CustomResponse" statusCode="403" subStatusCode="0" statusReason="Forbidden" statusDescription="Access is forbidden." />
2727
</rule>
2828

0 commit comments

Comments
 (0)