Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce user pics #9

Open
pookzilla opened this issue Dec 5, 2022 · 2 comments
Open

introduce user pics #9

pookzilla opened this issue Dec 5, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@pookzilla
Copy link
Collaborator

pookzilla commented Dec 5, 2022

Before I go too far down this rabbit hole and have the PR cleaned up I wanted to run this past you because it's a pretty significant departure from your original vision. I'm proposing UI changes as follows:

with user images disabled

snip for privacy

with user images enabled

snip for privacy

I wasn't originally intending move the toot ID to the right but I spent far too long trying to fix the alignment issues brought on by runewidth not reliably measuring the width of certain emojis. The problem is sidestepped by just putting it somewhere else and not worrying about right alignment.

At any rate, if you're ok with this change I'll get it cleaned up and performant.

@mrusme
Copy link
Owner

mrusme commented Dec 5, 2022

I like the idea! I think I'd go for slightly smaller avatars though, but maybe that could be made configurable. In any way feel free to change it this way, I think it's a lot better than what I put in place. 👍🏼

@mrusme mrusme added the enhancement New feature or request label Dec 5, 2022
@pookzilla
Copy link
Collaborator Author

super, thanks! And ya, the avatars definitely need some tweaking - My shell is usually much larger so they aren't so conspicuous but they're a bit much on a small display :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants