From bb7f0e794539ec15c45f323daddb6d2f195055c6 Mon Sep 17 00:00:00 2001 From: Xiping Yan Date: Tue, 23 Jul 2024 11:24:20 +0800 Subject: [PATCH] [CPU] Disable ConvertGatherToGatherCompressed optimization for quantized models (#25478) ### Details: - *Disable ConvertGatherToGatherCompressed pass in case `useLPT` is false* ### Tickets: - *138337* --------- Signed-off-by: xipingya --- .../convert_gather_to_compressed.cpp | 4 +- .../transformation_pipeline.cpp | 11 +- ...sable_gathercompressed_quantized_model.cpp | 144 ++++++++++++++++++ 3 files changed, 157 insertions(+), 2 deletions(-) create mode 100644 src/plugins/intel_cpu/tests/functional/custom/subgraph_tests/src/disable_gathercompressed_quantized_model.cpp diff --git a/src/common/transformations/src/transformations/op_conversions/convert_gather_to_compressed.cpp b/src/common/transformations/src/transformations/op_conversions/convert_gather_to_compressed.cpp index 3d1ad8ff2b3b6a..156481fb893227 100644 --- a/src/common/transformations/src/transformations/op_conversions/convert_gather_to_compressed.cpp +++ b/src/common/transformations/src/transformations/op_conversions/convert_gather_to_compressed.cpp @@ -134,7 +134,9 @@ ov::pass::ConvertGatherToGatherCompressed::ConvertGatherToGatherCompressed() { gather_input_scale); } - transformation_callback(new_gather_node); + if (transformation_callback(new_gather_node)) { + return false; + } result_nodes.push_back(new_gather_node); new_gather_node->set_friendly_name(gather_node->get_friendly_name()); diff --git a/src/plugins/intel_cpu/src/transformations/transformation_pipeline.cpp b/src/plugins/intel_cpu/src/transformations/transformation_pipeline.cpp index a77498cb5f4a4d..46b5a86f3a61fd 100644 --- a/src/plugins/intel_cpu/src/transformations/transformation_pipeline.cpp +++ b/src/plugins/intel_cpu/src/transformations/transformation_pipeline.cpp @@ -310,6 +310,7 @@ void Transformations::PreLpt(const std::vector& defaultPrecis ov::pass::Manager decompression_handling_manager; decompression_handling_manager.set_per_pass_validation(false); CPU_REGISTER_PASS_COMMON(decompression_handling_manager, ov::pass::InitNodeInfo); + const bool useLpt = !defaultPrecisions.empty(); CPU_REGISTER_PASS_COMMON(decompression_handling_manager, ov::pass::ConvertGatherToGatherCompressed); CPU_REGISTER_PASS_COMMON(decompression_handling_manager, ov::pass::MarkShapeOfSubgraphs); // We need to fuse Transpose to MatMul to have a simpler callback for the next transformation @@ -330,6 +331,15 @@ void Transformations::PreLpt(const std::vector& defaultPrecis if (ov::is_type(node)) { // It is necessary to avoid precision conversion for constant node(compressed weights) ov::enable_keep_const_precision(node->get_input_node_shared_ptr(0)); + + // Prioritize LPT pipeline to handle dequantization part for quantized models as it more optimal in + // general case + if (ov::intel_cpu::one_of(node->get_input_node_shared_ptr(0)->get_element_type(), + ov::element::u8, + ov::element::i8) && + useLpt) { + return true; + } } return false; }, @@ -338,7 +348,6 @@ void Transformations::PreLpt(const std::vector& defaultPrecis ov::pass::Manager manager; manager.set_per_pass_validation(false); - const bool useLpt = !defaultPrecisions.empty(); if (useLpt) CPU_REGISTER_PASS_COMMON(manager, ov::pass::MarkDequantizationSubgraph, defaultPrecisions); diff --git a/src/plugins/intel_cpu/tests/functional/custom/subgraph_tests/src/disable_gathercompressed_quantized_model.cpp b/src/plugins/intel_cpu/tests/functional/custom/subgraph_tests/src/disable_gathercompressed_quantized_model.cpp new file mode 100644 index 00000000000000..6df52b33e1a3fe --- /dev/null +++ b/src/plugins/intel_cpu/tests/functional/custom/subgraph_tests/src/disable_gathercompressed_quantized_model.cpp @@ -0,0 +1,144 @@ +// Copyright (C) 2024 Intel Corporation +// SPDX-License-Identifier: Apache-2.0 +// + +#include "common_test_utils/data_utils.hpp" +#include "common_test_utils/node_builders/constant.hpp" +#include "openvino/runtime/exec_model_info.hpp" +#include "shared_test_classes/base/ov_subgraph.hpp" + +namespace ov { +namespace test { +/* + * input2 + * | + * Constant(i8) Softmax + * | / + * Convert Multiply + * | / + * Multiply Convert input1(u8/i8) + * \ / | + * Gather FakeQuantize + * \ / + * \ / + * MatMul + */ +using DisableGatherCompressedForQuantizedModelParams = std::tuple; +class DisableGatherCompressedForQuantizedModel : public testing::WithParamInterface, + virtual public SubgraphBaseTest { +public: + static std::string getTestCaseName(testing::TestParamInfo obj) { + element::Type weight_prec; + InputShape inputShape1, inputShape2; + std::tie(weight_prec, inputShape1, inputShape2) = obj.param; + std::ostringstream result; + result << "weight_prec=" << weight_prec << "_" << "inputShape1=" << inputShape1 << "_" + << "inputShape2=" << inputShape2; + return result.str(); + } + +protected: + void SetUp() override { + targetDevice = utils::DEVICE_CPU; + element::Type weight_prec; + InputShape inputShape1, inputShape2; + std::tie(weight_prec, inputShape1, inputShape2) = GetParam(); + + init_input_shapes({inputShape1, inputShape2}); + + targetDevice = utils::DEVICE_CPU; + auto type = element::f32; + + auto input1 = std::make_shared(type, inputDynamicShapes[0]); + auto input2 = std::make_shared(type, inputDynamicShapes[1]); + + auto shared_il = op::v0::Constant::create(type, {1, 1, 1, 1}, {0.f}); + auto shared_ih = op::v0::Constant::create(type, {1, 1, 1, 1}, {12.5f}); + auto shared_ol = op::v0::Constant::create(type, {1, 1, 1, 1}, {0.f}); + auto shared_oh = op::v0::Constant::create(type, {1, 1, 1, 1}, {12.5f}); + auto fq = std::make_shared(input1, shared_il, shared_ih, shared_ol, shared_oh, 256); + + // Weights + auto weights_shape = Shape{64, 64}; + auto weights = utils::make_constant(weight_prec, weights_shape, utils::InputGenerateData(-1, 2, 32768)); + auto convert = std::make_shared(weights, element::f32); + auto multiply = std::make_shared(convert, op::v0::Constant::create(type, {1, 1}, {0.625})); + // Indics + auto softmax = std::make_shared(input2, 0); + auto multiply2 = std::make_shared(softmax, op::v0::Constant::create(type, {1}, {64})); + auto indics = std::make_shared(multiply2, element::i64); + // Gather + auto gather = + std::make_shared(multiply, indics, op::v0::Constant::create(element::i32, Shape{1}, {0})); + + auto matMul = std::make_shared(fq, gather, false, true); + + function = std::make_shared(matMul, ParameterVector{input1, input2}); + } + + void check_results() { + const auto& test_param = GetParam(); + const auto compressed_weights_precision = std::get<0>(test_param); + + const auto runtime_model = compiledModel.get_runtime_model(); + const auto matmul = runtime_model->get_result()->get_input_node_shared_ptr(0); + + bool have_gather = false; + bool have_gather_compressed = false; + for (const auto& n : runtime_model->get_ordered_ops()) { + const auto type = n->get_rt_info().at(ov::exec_model_info::LAYER_TYPE).as(); + if (type == "Gather") { + // Gather has >=4 inputs means it is GatherCompressed. + if (n->get_input_size() >= 4) { + have_gather_compressed = true; + } else { + have_gather = true; + } + } + } + + switch (compressed_weights_precision) { + case element::i8: + EXPECT_TRUE(have_gather); + EXPECT_EQ(matmul->get_input_element_type(1), element::i8); + // FakeQuantize(matmul's input(0))'s output precision is u8 + EXPECT_EQ(matmul->get_rt_info().at(ov::exec_model_info::RUNTIME_PRECISION).as(), + element::u8); + break; + case element::u8: + EXPECT_TRUE(have_gather); + // Current oneDNN MutMul official support precision: Source(u8, s8), Weights(s8). + // So reorder will be inserted when weights is not s8, don't need to check matmul's input(1) precision. + break; + case element::u4: + case element::i4: + EXPECT_TRUE(have_gather_compressed); + break; + default: + break; + } + } +}; + +TEST_P(DisableGatherCompressedForQuantizedModel, CompareWithRefs) { + SKIP_IF_CURRENT_TEST_IS_DISABLED() + run(); + check_results(); +} + +namespace { + +const std::vector inputShapes1 = {{{-1, 3, -1, -1}, {{1, 3, 64, 64}}}}; +const std::vector inputShapes2 = {{{}, {{32}}}}; +const std::vector weightsPrecisions = {element::i8, element::u8, element::u4, element::i4}; + +INSTANTIATE_TEST_SUITE_P(smoke_DisableGatherCompressedForQuantizedModel_basic, + DisableGatherCompressedForQuantizedModel, + ::testing::Combine(::testing::ValuesIn(weightsPrecisions), + ::testing::ValuesIn(inputShapes1), + ::testing::ValuesIn(inputShapes2)), + DisableGatherCompressedForQuantizedModel::getTestCaseName); + +} // namespace +} // namespace test +} // namespace ov