Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect use of "define-obsolete-variable-alias" #59

Closed
lbolla opened this issue Apr 1, 2021 · 3 comments · Fixed by #60
Closed

Incorrect use of "define-obsolete-variable-alias" #59

lbolla opened this issue Apr 1, 2021 · 3 comments · Fixed by #60

Comments

@lbolla
Copy link
Contributor

lbolla commented Apr 1, 2021

The use of define-obsolete-variable-alias is wrong here:

flycheck-pycheckers/flycheck-pycheckers.el

Line 206 in e8ce874

(define-obsolete-variable-alias 'flycheck-pycheckers-enabled-codes 'flycheck-pycheckers-enable-codes)

On Emacs tip, that function requires a third parameter, when:

(define-obsolete-variable-alias OBSOLETE-NAME CURRENT-NAME WHEN &optional
DOCSTRING)

Emacs version: GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.20, cairo version 1.16.0) of 2021-03-31
@lbolla
Copy link
Contributor Author

lbolla commented Apr 1, 2021

See also https://emba.gnu.org/emacs/emacs/-/commit/32c6732d16385f242b1109517f25e9aefd6caa5c

and a similar report in another project: emacs-eaf/emacs-application-framework#509

@hjpotter92
Copy link

And also at Malabarba/smart-mode-line#251

@msherry
Copy link
Owner

msherry commented Apr 13, 2021

Thanks for pointing out this issue! Pull requests are gratefully accepted, otherwise I'll have to see when I can get to this.

lbolla added a commit to lbolla/flycheck-pycheckers that referenced this issue Apr 14, 2021
@lbolla
Fix arguments in call to define-obsolete-variable-alias
4e6b927 
Use date and message from the commit that introduced the deprecation.

Fix msherry#59
@lbolla lbolla mentioned this issue Apr 14, 2021
Merged
msherry pushed a commit that referenced this issue Apr 14, 2021
@lbolla
Fix arguments in call to define-obsolete-variable-alias (#60)
771fb9a 
Use date and message from the commit that introduced the deprecation.

Fix #59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix arguments in call to define-obsolete-variable-alias lbolla/flycheck-pycheckers
3 participants
@lbolla @msherry @hjpotter92