Skip to content

motorola-ali: Additional functionality #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
jackmthws wants to merge 7 commits into
base: 6.13/main
Choose a base branch
from
Draft

motorola-ali: Additional functionality #225

jackmthws wants to merge 7 commits into from

Conversation

@jackmthws
Copy link

@jackmthws jackmthws commented Feb 26, 2025

These changes enable:

  • Magnometer
  • IMU
  • Charging LED
    and fixes:
  • SPI pin states (all msm8953)
  • Touchscreen sleep

@jackmthws jackmthws force-pushed the msm8953-6.13-ali-clean branch from df549a5 to 72349bd Compare February 26, 2025 07:54
barni2000
barni2000 requested changes Feb 26, 2025
View reviewed changes
Copy link
Member

@barni2000 barni2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bmi160 change should be sent upstream.

barni2000
barni2000 requested changes Feb 26, 2025
View reviewed changes
@jackmthws
Copy link
Author

jackmthws commented Feb 26, 2025

bmi160 change should be sent upstream.

Do you think it's acceptable upstream?

@barni2000
Copy link
Member

barni2000 commented Feb 26, 2025

bmi160 change should be sent upstream.

Do you think it's acceptable upstream?

It depends where this sleep should be? In the sensor driver or in the spi bus driver.

@jackmthws
Copy link
Author

jackmthws commented Feb 26, 2025

bmi160 change should be sent upstream.

Do you think it's acceptable upstream?

It depends where this sleep should be? In the sensor driver or in the spi bus driver.

I think it needs to be in the core driver because of it's location. It only activates when SPI is in use anyways.

@jackmthws jackmthws force-pushed the msm8953-6.13-ali-clean branch from 72349bd to 0007d7e Compare February 26, 2025 19:14
@jackmthws jackmthws requested a review from barni2000 February 26, 2025 19:15
@jackmthws
Copy link
Author

jackmthws commented Feb 26, 2025

seems like sleep pinctrl was not needed, only additional pin settings..

barni2000
barni2000 requested changes Feb 26, 2025
View reviewed changes
Copy link
Member

@barni2000 barni2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do the same pinctrl order change at all node? It can be a fixup commit.

@jackmthws jackmthws force-pushed the msm8953-6.13-ali-clean branch from 0007d7e to 9e7f592 Compare February 26, 2025 20:08
@barni2000
Copy link
Member

barni2000 commented Feb 26, 2025

Please add more description for this and send it to upstream eda1b0f

@jackmthws
Copy link
Author

jackmthws commented Feb 26, 2025

Please add more description for this and send it to upstream eda1b0f

QUP SPI still doesn't work. Maybe that commit is not needed for this spi-gpio.

@jackmthws jackmthws marked this pull request as draft March 2, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@barni2000 barni2000 barni2000 requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jackmthws @barni2000