Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unifieddyes functionality without base-mod/game #8

Open
BuckarooBanzay opened this issue Feb 24, 2022 · 3 comments
Open

unifieddyes functionality without base-mod/game #8

BuckarooBanzay opened this issue Feb 24, 2022 · 3 comments
Labels
question Further information is requested

Comments

@BuckarooBanzay
Copy link
Member

Continuing discussion from #5

What should the unifieddyes mod do on its own (without base-game or mod):

  • Should it include all possible dyes?
  • Should it just provide the airbrush and coloring functionality (including palettes) 👉 API?

I don't have an opinion on this yet as i don't know of any other mod than mtg dyes that implements the actual dyes
What are the other constellations this could be used in?

@wsor4035 @OgelGames

@OgelGames
Copy link
Contributor

From the readme:

The purpose of this mod originally was to supply a complete set of colors for Minetest mod authors to use for colorized nodes, or to reference in recipes. Since the advent of the default dyes mod in minetest_game, this mod has become more of an extension of the default mod. Since the advent of param2 colorization, it has also become a library for general color handling.

IMO we should go somewhat backwards in history, and have unifieddyes provide all possible dyes. (and when the dye mod does exist, override the items where needed)

@SwissalpS
Copy link
Contributor

wouldn't it be easier to maintain, if this mod didn't shadow dyes but just provided api to add and use colours?

@S-S-X
Copy link
Member

S-S-X commented Feb 25, 2022

What should the unifieddyes mod do on its own (without base-game or mod):

Probably nothing really, open dye system is complicated enough and could cover a lot of possible use cases with good API.

Should it include all possible dyes?

Could possibly include some dyes but not sure if that's really useful. Should include simple and straightforward way to introduce dyes.

Should it just provide the airbrush and coloring functionality (including palettes) 👉 API?

If API is planned then it should not provide airbrush, coloring functionality or palettes. It should provide API for these things.

If keeping backwards compatibility would mean adding another mod then I think that would be best way to handle mtg for example and every game of course could do whatever they want.
Even rename unifieddyes to unifieddyes_api and create new mods for unifieddyes airbrush / palettes / crafting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants