Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove _sound_def support method #4

Open
OgelGames opened this issue Feb 26, 2024 · 0 comments
Open

Remove _sound_def support method #4

OgelGames opened this issue Feb 26, 2024 · 0 comments

Comments

@OgelGames
Copy link
Contributor

OgelGames commented Feb 26, 2024

Reasoning:

  • Redundant - XCompat has no dependencies, and already optionally depends on games and mods, so why would a mod ever need to optionally depend on XCompat?
  • Hacky - It requires overriding minetest.register_node to support nodes that are added after mod loading. (see init.lua#L19-L36
  • Confusing - Reading the code of a mod that uses it, it's not clear what _sound_def is used for.
  • Unused - The only mods that use it (as far as I could find) are mt-mods/pipeworks, mt-mods/homedecor_modpack, and mt-mods/girder.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant