Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent device's SAMPLE's are missing UNITS type #513

Open
robot-ranger opened this issue Jan 14, 2025 · 3 comments
Open

Agent device's SAMPLE's are missing UNITS type #513

robot-ranger opened this issue Jan 14, 2025 · 3 comments

Comments

@robot-ranger
Copy link
Contributor

robot-ranger commented Jan 14, 2025

The Agent's own device SAMPLE dataitems are missing UNITS in streams documents.

The UNITS are specified in the Devices document (ie - probe), but missing in current and sample streams.

These are dataitems such as AssetUpdateRate and ObservationUpdateRate for each adapter that the agent is connected to.

This was discovered with https://validator.tams.ai

Also, https://model.mtconnect.org/#Structure___19_0_3_68e0225_1605104928558_860757_1123 shows multiplicity of "1" I assume that implies it is required.

@wsobel
Copy link
Member

wsobel commented Jan 14, 2025

I'll fix it in the next release.

@robot-ranger
Copy link
Contributor Author

I'll fix it in the next release.

not very critical; prioritize it as you will.

@robot-ranger
Copy link
Contributor Author

robot-ranger commented Jan 15, 2025

after discussion, this appears to be a model issue.

sysML does list units under each sample observation, possibly erroneously.

UNITS are a static definition; they ARE in model definition (ex probe, Devices response docs), but shouldnt be in the observations (ex current, sample, streams response docs).

The TYPE of a SAMPLE observation implies the units

TLDR; possibly not a cppagent issue. Ill leave this issue open for now until resolution, but feel free to close anytime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants