add response schemas and types #517
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsobel
approved these changes
Jan 16, 2025
|
hold off on this. i guess the order of the content responses implies the "default" response type. json has to be listed first in order for swagger-codegen to recognize the response type as ill submit another PR; dont merge this one. |
|
Got it. I'll wait. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added minimal response content spec to swagger generation. This should enable the use of https://github.com/swagger-api/swagger-codegen to generate functional swagger clients; returning the entire response doc from the agent.
I have tested with a generated python swagger client. I assume, but have not tested, it should enable functional, auto-generated, clients in any language swagger-codegen supports.
@mnoomnoo helped; i cant take all the credit.
fixes #515