Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coding/File Guidelines #114

Open
erictuvesson opened this issue Mar 10, 2020 · 4 comments
Open

Coding/File Guidelines #114

erictuvesson opened this issue Mar 10, 2020 · 4 comments

Comments

@erictuvesson
Copy link

erictuvesson commented Mar 10, 2020

It would be nice if there was some general guidelines.

Coding Guidelines

Since there is prettier installed and pre-commit hook, direct guidelines are not required.

File Guidelines

Right now the file names are not following the same format everywhere, would be nice to keep it consistent.

GitHub Labels

It would be nice if there were labels related to code area.

@ghost ghost added the Needs: triage 🔍 label Mar 10, 2020
@mtennoe
Copy link
Owner

mtennoe commented Mar 11, 2020

Another +1 from me!
It probably makes sense to create some guidelines before starting the other proposals/cleanups, as we then can move towards that goal from the start

@erictuvesson
Copy link
Author

@mtennoe is this something you want to start working on?

@mtennoe
Copy link
Owner

mtennoe commented Mar 11, 2020

Would love to do it. Based on current bandwidth due to work elsewhere I am not sure when I would have time to do it though, so I don't want to prevent others from giving it a shot if they want

@erictuvesson
Copy link
Author

I will be very busy the next few weeks, so I wouldn't have time to do it until next month. So up for grabs I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants