Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links on index & 404 page #101

Open
Leo-Mu opened this issue May 26, 2017 · 5 comments
Open

Links on index & 404 page #101

Leo-Mu opened this issue May 26, 2017 · 5 comments

Comments

@Leo-Mu
Copy link
Contributor

Leo-Mu commented May 26, 2017

Why not link to everyone's file in the humans directory?

Well. Now on the index page, we can only see the link to human.txt and some links to everyone's GitHub profile. If I want to see a page someone created in humans directory, it will be hard to find it. Why not write a piece of JavaScript to display links to pages in the humans directory rather than GitHub profiles.

Do you need a 404 page?

I found there is no a particular 404 page. If the URL is wrong, it will display the boring GitHub 404 page.

@SubhrajyotiSen
Copy link
Collaborator

@muan This sounds like a good idea

@zwirektech
Copy link
Contributor

zwirektech commented Jun 5, 2017

I agree about the files in humans directory. It has been discussed a little in my first PR.
Since the picture is a link to the user's profile, there could be a filename under the picture as a link to the file in humans folder.
However, the filename doesn't have to be the same as a username in human.txt
Actually it's not the same in many cases.
I think just a list of humans folder content with links to individual files would be ok.

The 404 could be another issue...

@aaossa
Copy link
Contributor

aaossa commented Feb 9, 2018

@muan any opinions on this? 🤔

@muan
Copy link
Owner

muan commented Jul 18, 2018

Why not link to everyone's file in the humans directory?

We could. The only problem is we didn't restrict what kind of file people can put in the repo. It could be .md or .html or .txt etc. I didn't want having to write HTML to be a blocker. But perhaps that's not that big of an issue?

Or we could do something clever with JS fetch to test what type of file by a name exist and then redirect people to that URL.

Do you need a 404 page?

404 would be good. I can go hand in hand with that ^ redirection idea.

@leewp14
Copy link
Collaborator

leewp14 commented Jul 19, 2018

Hi there!
I made a very very very simple list of humans, testing indicates that txt, md and html is ok to open directly, except for those without a file extension.
Here I attached the html file, don't know whether it can be used 😄

test.html.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants