Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors with shadow-dom branch #148

Closed
maenkhouseh opened this issue Dec 18, 2024 · 9 comments
Closed

Errors with shadow-dom branch #148

maenkhouseh opened this issue Dec 18, 2024 · 9 comments
Assignees
Labels
bug Something isn't working question Further information is requested

Comments

@maenkhouseh
Copy link

Once I run pnpm run dev after switching to the shadow-dom branch I get so many errors in console (and the extension losses style), the errors look as such:

transforming...
[0] 5:02:41 PM [vite] (client) Pre-transform error: [sass] File URL path must be absolute
[0]   ╷
[0] 2 │ @use '/node_modules/vite-plugin-vue-devtools/src/overlay/devtools-overlay.css';
[0]   │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[0]   ╵
[0]   src\assets\base.scss 2:1           @use
[0]   src\content-script\index.scss 1:1  root stylesheet
[0]   Plugin: vite:css
[0]   File: D:/dev-new/tendersalerts-extension/src/content-script/index.scss?inline
[0]   [sass] File URL path must be absolute
[0]     ╷
[0]   2 │ @use '/node_modules/vite-plugin-vue-devtools/src/overlay/devtools-overlay.css';
[0]     │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[0]     ╵
[0]     src\assets\base.scss 2:1           @use
[0]     src\content-script\index.scss 1:1  root stylesheet

Correct me if I am testing this in a wrong manner please, or let me know how to fix this, thanks in advance

@mubaidr
Copy link
Owner

mubaidr commented Dec 18, 2024

Did you do pnpm i before the dev?

@mubaidr mubaidr self-assigned this Dec 18, 2024
@mubaidr mubaidr added bug Something isn't working question Further information is requested labels Dec 18, 2024
@maenkhouseh
Copy link
Author

of course

@maenkhouseh
Copy link
Author

in base.scss
using this:
@use '../../node_modules/vite-plugin-vue-devtools/src/overlay/devtools-overlay.css';

fixes the issue

daisyui works now in the shadow-dom version?

@mubaidr
Copy link
Owner

mubaidr commented Dec 18, 2024

What os are you on?

@maenkhouseh
Copy link
Author

currently windows

@mubaidr
Copy link
Owner

mubaidr commented Dec 18, 2024

Just tested on linux, no errors during dev or build.

pnpm dev:chrome

> [email protected] dev:chrome /projects/vite-vue3-chrome-extension-v3
> vite -c vite.chrome.config.ts

Re-optimizing dependencies because lockfile has changed

  VITE v6.0.3  ready in 4783 ms

  ➜  Local:   http://localhost:5173/
  ➜  Network: use --host to expose
  ➜  Vue DevTools: Open http://localhost:5173/__devtools__/ as a separate window
  ➜  Vue DevTools: Press Alt(⌥)+Shift(⇧)+D in App to toggle the Vue DevTools

  ➜  press h + enter to show help

Maybe we need to test on windows specifically?

@maenkhouseh
Copy link
Author

Yes, once updated, it worked and I ll test build and let you know

@maenkhouseh
Copy link
Author

but daisyui seems not working, any fix?

@maenkhouseh
Copy link
Author

Tried many things to make it work but none worked, any suggestions?

Repository owner locked and limited conversation to collaborators Dec 21, 2024
@mubaidr mubaidr converted this issue into discussion #150 Dec 21, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants