Skip to content

fix(reranker): llama-cpp sort score desc, crop top_n #7211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2025
Merged

fix(reranker): llama-cpp sort score desc, crop top_n #7211

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
897ece6
fix(reranker): llama-cpp sort score desc, crop top_n
mkhludnev Nov 9, 2025
7d199e7
Merge branch 'master' into llama-cpp-rerank-sort-crop-fix
mkhludnev Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions backend/cpp/llama-cpp/grpc-server.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1394,7 +1394,16 @@ class BackendServiceImpl final : public backend::Backend::Service {
if (error) {
return grpc::Status(grpc::StatusCode::INTERNAL, "Error in receiving results");
}
// Sort responses by score in descending order
std::sort(responses.begin(), responses.end(), [](const json& a, const json& b) {
return a.value("score", 0.0f) > b.value("score", 0.0f);
});

// Crop results by request.top_n if specified
int top_n = request->top_n();
if (top_n > 0 && top_n < static_cast<int>(responses.size())) {
responses = json(responses.begin(), responses.begin() + top_n);
}
// Set usage information
backend::Usage* usage = rerankResult->mutable_usage();
int total_tokens = 0;
Expand Down
Loading