Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine/KVO Compliance #469

Open
bilalb opened this issue Sep 18, 2020 · 2 comments
Open

Combine/KVO Compliance #469

bilalb opened this issue Sep 18, 2020 · 2 comments

Comments

@bilalb
Copy link

bilalb commented Sep 18, 2020

First of all, thanks for the great work on that library.

It would be great if the objects used in project (especially FSAudioController & FSAudioStream) would be KVO compliant.
That would enable Combine support and make the library more convenient to use.
I'd be glad to help with that.

Thanks in advance :)

@muhku
Copy link
Owner

muhku commented Sep 21, 2020

Sure, this would be a good thing. I can take a look at any PRs.

@bilalb
Copy link
Author

bilalb commented Sep 23, 2020

I don't have much experience with Objective-C and it's been a while I haven't used it.
Also, KVO compliance doesn't look that trivial.

If someone could provide an example applied to the library that I could follow and apply to the other classes that'd be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants