Repository navigation
[select] Ignore unrelated mouseup after a fast trigger click - #6048
Merged
Merged
Conversation
atomiks
added
component: select
commit: |
Bundle size
PerformanceNo regressions in 36 benchmarks · ran 3m 59s · details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
atomiks
marked this pull request as ready for review
October 22, 2026 09:36
atomiks
requested review from
colmtuite,
flaviendelangle,
jjenzz and
michaldudak
as code owners
October 22, 2026 09:36
3 tasks done
github-actions
Bot
added
the
PR: out-of-date
atomiks
force-pushed
the
select-stale-mouseup-listener
branch
from
November 10, 2026 04:55
a1cadd7 to
3401369
Compare
github-actions
Bot
removed
the
PR: out-of-date
atomiks
enabled auto-merge (squash)
November 10, 2026 04:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6042
Select.Triggerattached its documentmouseuplistener in a 0 ms timeout. When the opening press was released before that timeout ran (a trackpad tap or a very fast click), the listener missed it and stayed registered, so the next unrelated release, such as dragging out of the popup, closed the Select.This PR adds the listener synchronously in
onMouseDown, likeMenuTriggerandComboboxTriggeralready do. The timeout's "Firefox can fire this upon mousedown" comment no longer applies: in Firefox 158, opening, press-drag-to-select, drag-off-to-cancel and touch taps all behave the same with and without item alignment.