Repository navigation
Conversation
atomiks
added
component: drawer
commit: |
Bundle size
PerformanceNo regressions in 36 benchmarks · ran 3m 57s · details Check out the code infra dashboard for more information about this PR. |
✅ Deploy Preview for base-ui ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
atomiks
marked this pull request as ready for review
October 29, 2026 06:41
atomiks
requested review from
colmtuite,
flaviendelangle,
jjenzz and
michaldudak
as code owners
October 29, 2026 06:41
atomiks
force-pushed
the
claude/drawer-swipe-open-first-frame
branch
from
November 10, 2026 04:55
f605f46 to
f771d6c
Compare
atomiks
enabled auto-merge (squash)
November 10, 2026 04:56
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6105
A drawer opened by a swipe on
Drawer.SwipeAreapainted its first frame away from the pointer. The popup mounts one commit afteropenflips, and the swipe area neither re-rendered in that commit nor re-applied a movement it had never managed to apply, so the popup had no--drawer-swipe-movement-*until the nextpointermove. It also mounted withdata-starting-style, whose transform in the documented styles overrides the movement for that frame.This PR subscribes the swipe area to
popupElementand applies the movement in that commit when the swipe opened the drawer (as proposed by @klemenoslaj in the issue), and removes the popup's starting style once the swipe places it, since it then follows the pointer instead of transitioning in. A flick that only opens the drawer on release keeps its starting style and transitions in as before.