Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select Option Popover not positioned correctly #16674

Closed
2 tasks done
rakshans1 opened this issue Jul 22, 2019 · 3 comments
Closed
2 tasks done

Select Option Popover not positioned correctly #16674

rakshans1 opened this issue Jul 22, 2019 · 3 comments
Labels
bug 🐛 Something doesn't work component: menu This is the name of the generic UI component, not the React module! port-to-base-ui PR to be included in the Base UI repository once the API changes are done

Comments

@rakshans1
Copy link

Select component popover is not positioned correctly when the option is a long list and the selected option is not in the top

  • This is not a v0.x issue.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

Option position gets misplaced when to selected option goes down the list

Steps to Reproduce 🕹

Link:

  1. https://codesandbox.io/s/laughing-tree-d1epm

Your Environment 🌎

Tech Version
Material-UI v4.2.1
React v16.8.6
@eps1lon eps1lon added component: menu This is the name of the generic UI component, not the React module! bug 🐛 Something doesn't work labels Jul 24, 2019
@eps1lon
Copy link
Member

eps1lon commented Jul 24, 2019

An issue with where the contentAnchor for the Popover is determined in Menu. It's one of the concerns I had while rewriting the tests. It's probably easier to have the Popover position fixed but scroll to the selected element instead doing position calculations. Those are always tricky and do not compose well with custom styling.

I think it's better to rework how dropdowns are displayed (actual dropdown) instead of fixing this issue. But if someone has a fix I'm happy to accept a PR.

@siriwatknp
Copy link
Member

Base UI should handle this behavior.

@siriwatknp siriwatknp added the port-to-base-ui PR to be included in the Base UI repository once the API changes are done label Nov 19, 2024
Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Note

@rakshans1 How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: menu This is the name of the generic UI component, not the React module! port-to-base-ui PR to be included in the Base UI repository once the API changes are done
Projects
None yet
Development

No branches or pull requests

3 participants