Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Grid2] codemod migrating to Grid2 not working #44497

Closed
shifoc opened this issue Nov 21, 2024 · 4 comments
Closed

[Grid2] codemod migrating to Grid2 not working #44497

shifoc opened this issue Nov 21, 2024 · 4 comments
Assignees
Labels
component: Grid The React component. status: waiting for author Issue with insufficient information

Comments

@shifoc
Copy link

shifoc commented Nov 21, 2024

Steps to reproduce

I am migrating from Grid to Grid2

I changed the imports:
-import Grid from '@mui/material/Grid';
+import Grid from '@mui/material/Grid2';

and Run the codemod:
npx @mui/codemod@latest v6.0.0/grid-v2-props <path/to/folder>

it did not change anything

Current behavior

No response

Expected behavior

No response

Context

No response

Your environment

System:
OS: Windows 10 10.0.19045
Binaries:
Node: 18.18.0 - C:\Program Files\nodejs\node.EXE
npm: 9.8.1 - C:\Program Files\nodejs\npm.CMD
pnpm: Not Found
Browsers:
Chrome: Not Found
Edge: Chromium (127.0.2651.74)

Search keywords: Grid Grid2

@shifoc shifoc added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Nov 21, 2024
@shifoc
Copy link
Author

shifoc commented Nov 21, 2024

EDIT: After trying again multiple times it worked but it's always adding unnecessary parenthesis

@sai6855 sai6855 added component: Grid The React component. status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Nov 21, 2024
@sai6855
Copy link
Contributor

sai6855 commented Nov 21, 2024

@shifoc Can you share git repo or minimal example to reproduce your issue?

@DiegoAndai DiegoAndai self-assigned this Nov 21, 2024
@DiegoAndai
Copy link
Member

Thanks for the report @shifoc, and I'm glad that it worked.

it's always adding unnecessary parenthesis

We recommend running your code formatter after running the codemods, for example, running prettier if that's what you use. This is because we don't know each user's formatting settings and/or tools, so we cannot fix it on our side.

Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Note

@shifoc How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Grid The React component. status: waiting for author Issue with insufficient information
Projects
None yet
Development

No branches or pull requests

3 participants