Add json to eslint #746
Merged
Add json to eslint #746
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle size report
Check out the code infra dashboard for more information about this PR. |
Janpot
added
the
scope: code-infra
oliviertassinari
temporarily deployed
to
json-linting - mui-tools-public PR #746
Render
Destroyed
brijeshb42
reviewed
Sep 26, 2025
eslint.config.mjs
Outdated
| const dirname = path.dirname(filename); | ||
|
|
||
| export default defineConfig( | ||
| createJsonConfig(), |
Contributor
There was a problem hiding this comment.
Can you verify if this also include files inside node_modules or other ignored directories, since the ignore logic is added in createBaseConfig() ?
Member
Author
There was a problem hiding this comment.
ignores are global, for the whole configuration, their order does only matter in a sense that other ignores can include or exclude more files. Maybe createBaseconfig should just contain the json config? That'll likely be a breaking change on some repos as you need to specifically target js files to alter js rules.
brijeshb42
reviewed
Sep 26, 2025
Contributor
|
Since we are going with breaking change, does it also makes sense to remove the jsonlint CI ? |
github-actions
bot
added
the
PR: out-of-date
oliviertassinari
temporarily deployed
to
json-linting - mui-tools-public PR #746
Render
Destroyed
github-actions
bot
removed
the
PR: out-of-date
oliviertassinari
temporarily deployed
to
json-linting - mui-tools-public PR #746
Render
Destroyed
This was referenced Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
export json configuration for eslint
closes #550
Also closes #743
This requires bigger refactor of our shareable configs than I initially assumed.
according to JoshuaKGoldberg/eslint-plugin-package-json#1265 (comment)
They're changing their stance on how to define shareable configs
Canary PRs:
@eslint/jsonbase-ui#2964