From 78d3bf79ce569f7d49bca8cf12b3c03f8fd7d4d0 Mon Sep 17 00:00:00 2001 From: Janpot <2109932+Janpot@users.noreply.github.com> Date: Wed, 1 Oct 2025 13:08:21 +0200 Subject: [PATCH 1/3] [code-infra] Pass through ARGOS_THRESHOLD variable --- packages/code-infra/src/cli/cmdArgosPush.mjs | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/code-infra/src/cli/cmdArgosPush.mjs b/packages/code-infra/src/cli/cmdArgosPush.mjs index b7f962f79..20ca6ee16 100644 --- a/packages/code-infra/src/cli/cmdArgosPush.mjs +++ b/packages/code-infra/src/cli/cmdArgosPush.mjs @@ -99,6 +99,7 @@ export default /** @type {import('yargs').CommandModule<{}, Args>} */ ({ commit: circleSha1, branch: circleBranch, token: argosToken, + threshold: process.env.ARGOS_THRESHOLD ? parseFloat(process.env.ARGOS_THRESHOLD) : 0.5, parallel: { total: batches.length, nonce: circleBuildNum, From 1f501ba73d7625611d593ed7b433ed657190c03a Mon Sep 17 00:00:00 2001 From: Janpot <2109932+Janpot@users.noreply.github.com> Date: Wed, 1 Oct 2025 13:31:15 +0200 Subject: [PATCH 2/3] Update cmdArgosPush.mjs --- packages/code-infra/src/cli/cmdArgosPush.mjs | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/packages/code-infra/src/cli/cmdArgosPush.mjs b/packages/code-infra/src/cli/cmdArgosPush.mjs index 20ca6ee16..8410d47af 100644 --- a/packages/code-infra/src/cli/cmdArgosPush.mjs +++ b/packages/code-infra/src/cli/cmdArgosPush.mjs @@ -63,6 +63,7 @@ export default /** @type {import('yargs').CommandModule<{}, Args>} */ ({ const screenshots = await globby(`${folder}/**/*`, { onlyFiles: true, }); + const threshold = process.env.ARGOS_THRESHOLD ? parseFloat(process.env.ARGOS_THRESHOLD) : 0.5; console.log(`Found ${screenshots.length} screenshots.`); if (verbose) { @@ -99,15 +100,22 @@ export default /** @type {import('yargs').CommandModule<{}, Args>} */ ({ commit: circleSha1, branch: circleBranch, token: argosToken, - threshold: process.env.ARGOS_THRESHOLD ? parseFloat(process.env.ARGOS_THRESHOLD) : 0.5, + threshold, parallel: { total: batches.length, nonce: circleBuildNum, }, }); + if (verbose) { + console.log('Screenshots uploaded:'); + for (const screenshot of result.screenshots) { + console.log(`- ${screenshot.name}. Threshold: ${screenshot.threshold}.`); + } + } + console.log( - `Batch of ${batches[i].length} screenshots uploaded. Build URL: ${result.build.url}`, + `Batch of ${batches[i].length} screenshots uploaded. Threshold: ${threshold}. Build URL: ${result.build.url}`, ); } } finally { From e1c0636c9be7dedbc235478672033d7407672e2d Mon Sep 17 00:00:00 2001 From: Janpot <2109932+Janpot@users.noreply.github.com> Date: Wed, 1 Oct 2025 13:37:23 +0200 Subject: [PATCH 3/3] Update cmdArgosPush.mjs --- packages/code-infra/src/cli/cmdArgosPush.mjs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/code-infra/src/cli/cmdArgosPush.mjs b/packages/code-infra/src/cli/cmdArgosPush.mjs index 8410d47af..1f69e13d8 100644 --- a/packages/code-infra/src/cli/cmdArgosPush.mjs +++ b/packages/code-infra/src/cli/cmdArgosPush.mjs @@ -65,7 +65,9 @@ export default /** @type {import('yargs').CommandModule<{}, Args>} */ ({ }); const threshold = process.env.ARGOS_THRESHOLD ? parseFloat(process.env.ARGOS_THRESHOLD) : 0.5; - console.log(`Found ${screenshots.length} screenshots.`); + console.log( + `Found ${screenshots.length} screenshots. Uploading with threshold ${threshold}.`, + ); if (verbose) { console.log('Screenshots found:'); screenshots.forEach((screenshot) => {