[data grid] processRowUpdate - pass the modified row index in the arguments

[TeoAvignon]

Summary

Currently, the function arguments are oldRow, newRow, params which only has rowId inside.

If your data is an array, it means updating it will be O(n) while it could be O(1) with the row index.

Could you please also give the row index. Thus, people could choose between the index and the id to update their data based on their current implementation (array or dictionnary)

Examples

Motivation

I would like to improve the performance of my app

Search keywords: processRowUpdate, index

Order ID: #42756

[michelengelen]

Hey @TeoAvignon I don't think we can support this, as we only store the relative index and not the index it has on the original array ... i might be mistaken though.

I know that @romgrk is advocating to use Map instead of Array as a form of passing the rows to increase DX and performance, but I am not sure how far he has gotten with this yet.

what we can provide is the relative index using apiRef: apiRef.current?.getRowIndexRelativeToVisibleRows(params.rowId)

@MBilalShafi do you have any additional information on this?

[TeoAvignon]

Thanks for your quick response @michaelNXT1 !

For the apiRef, I think it is equivalent to a find isn't it ?

[romgrk]

I don't think that we maintain an id->index lookup for this case. We maintain one for rows after sorting, because we need that ordering for rendering purposes, but we don't maintain one for the original dataset as it doesn't make sense for us to do it for everyone just to provide that parameter. I suggest that you create an id->index Map on your side.

[TeoAvignon]

Seems ok to me ! Thanks for responding so quickly. I'll use this solution.

[github-actions]

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Note

@TeoAvignon How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.