Skip to content
This repository has been archived by the owner on Jan 19, 2024. It is now read-only.

Global "header"s wiped on "extend" #14

Open
wilkohein opened this issue Jan 16, 2017 · 1 comment
Open

Global "header"s wiped on "extend" #14

wilkohein opened this issue Jan 16, 2017 · 1 comment

Comments

@wilkohein
Copy link

Global headers provided on client init do not work.
Reason: Every function call uses something like
{code}
var options = extend({ body: body, headers: {} }, opts)
{code}
i.e. forcefully defines a "headers" attribute. On the used "xtend" version of extend this is therefore overriding any global options set:
{code}
var options = extend({}, client._options, opts)
{code}

Resolution: Use version of "extend" supporting recursive extension.

@sichvoge
Copy link

sichvoge commented Mar 9, 2017

@wilkohein, can you contact me on christian dot vogel at mulesoft dot com? I saw your new implementation or fork and I wasn't able to raise any issues. Like to speak to you about that :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants