Fix off-screen element detection issue

Author: mojganii

ios/MullvadVPN/View controllers/VPNSettings/VPNSettingsDataSource.swift

@@ -457,6 +457,7 @@ final class VPNSettingsDataSource: UITableViewDiffableDataSource<
         header.accessibilityIdentifier = .wireGuardPortsCell
         header.titleLabel.text = title
         header.accessibilityCustomActionName = title
+        header.isExpanded = isExpanded(.wireGuardPorts)
         header.infoButtonHandler = { [weak self] in
             if let self {
                 self.delegate?.showInfo(for: .wireGuardPorts)
@@ -500,6 +501,7 @@ final class VPNSettingsDataSource: UITableViewDiffableDataSource<
         header.accessibilityIdentifier = .wireGuardObfuscationCell
         header.titleLabel.text = title
         header.accessibilityCustomActionName = title
+        header.isExpanded = isExpanded(.wireGuardObfuscation)
         header.didCollapseHandler = { [weak self] header in
             guard let self else { return }
 
@@ -529,6 +531,7 @@ final class VPNSettingsDataSource: UITableViewDiffableDataSource<
         header.accessibilityIdentifier = .udpOverTCPPortCell
         header.titleLabel.text = title
         header.accessibilityCustomActionName = title
+        header.isExpanded = isExpanded(.wireGuardObfuscationPort)
         header.didCollapseHandler = { [weak self] header in
             guard let self else { return }
 
@@ -558,6 +561,7 @@ final class VPNSettingsDataSource: UITableViewDiffableDataSource<
         header.accessibilityIdentifier = .quantumResistantTunnelCell
         header.titleLabel.text = title
         header.accessibilityCustomActionName = title
+        header.isExpanded = isExpanded(.quantumResistance)
         header.didCollapseHandler = { [weak self] header in
             guard let self else { return }
 
@@ -593,6 +597,11 @@ final class VPNSettingsDataSource: UITableViewDiffableDataSource<
 
         return nil
     }
+
+    private func isExpanded(_ section: Section) -> Bool {
+        let snapshot = snapshot()
+        return snapshot.numberOfItems(inSection: section) != 0
+    }
 }
 
 extension VPNSettingsDataSource: VPNSettingsCellEventHandler {

ios/MullvadVPNUITests/Pages/VPNSettingsPage.swift

@@ -15,10 +15,11 @@ class VPNSettingsPage: Page {
     }
 
     private func cellExpandButton(_ cellAccessiblityIdentifier: AccessibilityIdentifier) -> XCUIElement {
-        let table = app.tables[AccessibilityIdentifier.vpnSettingsTableView]
-        let matchingCells = table.otherElements.containing(.any, identifier: cellAccessiblityIdentifier.rawValue)
+        let tableView = app.tables[AccessibilityIdentifier.vpnSettingsTableView]
+        let matchingCells = tableView.otherElements[cellAccessiblityIdentifier.rawValue]
         let expandButton = matchingCells.buttons[AccessibilityIdentifier.expandButton]
-
+        let lastCell = tableView.cells.allElementsBoundByIndex.last!
+        tableView.scrollUpToElement(element: lastCell)
         return expandButton
     }
 

ios/MullvadVPNUITests/XCUIElement+Extensions.swift

@@ -16,4 +16,25 @@ extension XCUIElement {
         _ = XCTWaiter().wait(for: [expectation], timeout: timeout)
         return !exists
     }
+
+    func scrollUpToElement(element: XCUIElement, maxScrolls: UInt = 5) {
+        var count = 0
+        while !element.isVisible && count < maxScrolls {
+            swipeUp()
+            count += 1
+        }
+    }
+
+    func scrollDownToElement(element: XCUIElement, maxScrolls: UInt = 5) {
+        var count = 0
+        while !element.isVisible && count < maxScrolls {
+            swipeDown()
+            count += 1
+        }
+    }
+
+    var isVisible: Bool {
+        guard self.exists && !self.frame.isEmpty else { return false }
+        return XCUIApplication().windows.element(boundBy: 0).frame.contains(self.frame)
+    }
 }