Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting for maximum size of album cover art #77

Closed
wants to merge 1 commit into from

Conversation

fstiewitz
Copy link

Fixes #60

@multani
Copy link
Owner

multani commented Jun 4, 2015

Hi Fabian,

thank you very much for this your fix! Sorry I didn't answered earlier but I was busy with other things.

I had a look and tested your patch and it works almost OK :) There are 2 minor issues that would be cool to address though:

  • it seems that if you manually enter a value for the maximum size of the cover, the setting doesn't get saved. If I set an arbitrary number (without clicking on the +/- buttons), close the preferences window and re-open it, I still have the value I had before I changed it.
  • do you think you can have a look at resizing the cover if the maximum cover size value has changed? Currently you need to click on the cover to make it small and then reclick it again to trigger the resize with the max size setting applied. It would be cool if it gets resized directly.

@multani
Copy link
Owner

multani commented Jun 4, 2015

On a side note, I was wondering if being able to set the maximum size is really what we want here.

There is actually lot of space on the right side of the window on the same level as the cover. So, instead of adding a new option, with probably hard to figure out numbers on what a good maximum size should be, it would be actually nice to be able to compute a size which fits the screen and move the lyrics on the right side of the screen, using all this blank space.

So, there would be 2 parts:

  • move the lyrics panel on the right side
  • compute a pretty good maximum cover size. That would be something like this:
    • the width should be no more than half of the screen or window's size, so that we have enough space then on the right side to put the information about the album and the lyrics.
    • the height should be no as big as it can so it fits all the available height of the panel, but it should also not be too big so that we can see all the cover at all times.

This would remove the additional options and settings in the preferences and also solve the initial problem (covers can be too big).

@deprint Would you be interested to have a look on this?

@fstiewitz
Copy link
Author

I like the idea with the lyrics panel on the right side. I'll see what I can do and open a new PR ;)

@fstiewitz fstiewitz closed this Jun 4, 2015
@fstiewitz fstiewitz deleted the max-cover-art-size branch June 9, 2015 15:26
@fstiewitz fstiewitz mentioned this pull request Jun 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Size of the local covers in infos tab
2 participants