Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update qemu-binfmt-conf.sh to support loongarch64 #189

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

update qemu-binfmt-conf.sh to support loongarch64 #189

wants to merge 1 commit into from

Conversation

zhangguanzhang
Copy link

@zhangguanzhang zhangguanzhang commented Mar 6, 2023 •
edited
Loading

Fixes: #188

@zhangguanzhang
Copy link
Author

zhangguanzhang commented Mar 6, 2023 •
edited
Loading

@lafin PTAL

@loongson-zn
Copy link

loongson-zn commented Dec 4, 2023 •
edited
Loading

@lafin What ideas do you have for supporting LoongArch? multiarch/qemu-user-static is important in cross world, looking forward to supporting LoongArch.
I have verified it's correct through LoongArch sbuildQEMU on debian community.

leavelet
leavelet reviewed May 14, 2024
View reviewed changes
containers/latest/register.sh
@@ -1,7 +1,7 @@
#!/bin/sh

QEMU_BIN_DIR=${QEMU_BIN_DIR:-/usr/bin}

QEMU_SUFFIX=${QEMU_SUFFIX:--static}
Copy link

@leavelet leavelet May 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qemu-user-static shoud be statically linked. Simply rename qemu-user to qemu-user-static will not work as expected. So -static suffix is not optional.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

qemu-user-static shoud be statically linked. Simply rename qemu-user to qemu-user-static will not work as expected. So -static suffix is not optional.

This was the default behavior before. I just added the variable default value so that it can be configured through variables.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the default value should be changed. -static is necessary for binfmt to work properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leavelet leavelet leavelet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

need to upgrade to support loongarch64
3 participants
@zhangguanzhang @loongson-zn @leavelet