Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p2p-circuit was not supported #109

Closed
godcong opened this issue Sep 17, 2019 · 4 comments
Closed

p2p-circuit was not supported #109

godcong opened this issue Sep 17, 2019 · 4 comments

Comments

@godcong
Copy link
Contributor

godcong commented Sep 17, 2019

[email protected] ->
swarm.go ->
out.addr, err = multiaddr.NewMultiaddr(conn.Addr)

if conn.Addr is a p2p-circuit address like

/ipfs/QmdGQoGuK3pao6bRDqGSDvux5SFHa4kC2XNFfHFcvcbydY/p2p-circuit/ipfs/QmcCnisUqm75ghwMSb8k1dJXvn9d6usK7pd9NzWqDZn8XG

this api will return an err

panic: failed to parse multiaddr "/ipfs/QmdGQoGuK3pao6bRDqGSDvux5SFHa4kC2XNFfHFcvcbydY/p2p-circuit": unknown protocol p2p-circuit
@Stebalien
Copy link
Member

See #108. The issue is that we need to import github.com/libp2p/go-libp2p-circuit to get the address definition.

@Stebalien
Copy link
Member

Closing as a duplicate.

@godcong
Copy link
Contributor Author

godcong commented Sep 17, 2019

so quickly, 👍

@Stebalien
Copy link
Member

@godcong do you have time to fix #108 and move the protocol definitions (https://github.com/libp2p/go-libp2p-circuit/blob/master/transport.go#L13-L24)? It's not tricky, just something we need to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants