fixes after second review

Author: sstanculeanu

Diff for: epochStart/metachain/baseRewards_test.go

@@ -1168,13 +1168,13 @@ func getBaseRewardsArguments() BaseRewardsCreatorArgs {
 	rewardsTopUpGradientPoint, _ := big.NewInt(0).SetString("3000000000000000000000000", 10)
 
 	rewardsHandler := &mock.RewardsHandlerStub{
-		RewardsTopUpGradientPointInEpochCalled: func(epoch uint32) *big.Int {
+		RewardsTopUpGradientPointInEpochCalled: func(_ uint32) *big.Int {
 			return rewardsTopUpGradientPoint
 		},
-		RewardsTopUpFactorInEpochCalled: func(epoch uint32) float64 {
+		RewardsTopUpFactorInEpochCalled: func(_ uint32) float64 {
 			return 0.25
 		},
-		ProtocolSustainabilityAddressInEpochCalled: func(epoch uint32) string {
+		ProtocolSustainabilityAddressInEpochCalled: func(_ uint32) string {
 			return "11"
 		},
 	}

Diff for: epochStart/metachain/economics_test.go

@@ -1585,19 +1585,19 @@ func createArgsForComputeEndOfEpochEconomics(
 		MaxInflationRateCalled: func(_ uint32) float64 {
 			return 0.1
 		},
-		ProtocolSustainabilityAddressInEpochCalled: func(epoch uint32) string {
+		ProtocolSustainabilityAddressInEpochCalled: func(_ uint32) string {
 			return commAddress
 		},
-		ProtocolSustainabilityPercentageInEpochCalled: func(epoch uint32) float64 {
+		ProtocolSustainabilityPercentageInEpochCalled: func(_ uint32) float64 {
 			return 0.1
 		},
-		LeaderPercentageInEpochCalled: func(epoch uint32) float64 {
+		LeaderPercentageInEpochCalled: func(_ uint32) float64 {
 			return 0.1
 		},
-		RewardsTopUpFactorInEpochCalled: func(epoch uint32) float64 {
+		RewardsTopUpFactorInEpochCalled: func(_ uint32) float64 {
 			return 0.25
 		},
-		RewardsTopUpGradientPointInEpochCalled: func(epoch uint32) *big.Int {
+		RewardsTopUpGradientPointInEpochCalled: func(_ uint32) *big.Int {
 			return big.NewInt(0).Div(args.GenesisTotalSupply, big.NewInt(10))
 		},
 	}

Diff for: epochStart/metachain/rewardsV2_test.go

@@ -1767,10 +1767,10 @@ func getRewardsCreatorV2Arguments() RewardsCreatorArgsV2 {
 	topUpRewardFactor := 0.25
 
 	rewardsHandler := &economicsmocks.EconomicsHandlerMock{
-		RewardsTopUpGradientPointInEpochCalled: func(epoch uint32) *big.Int {
+		RewardsTopUpGradientPointInEpochCalled: func(_ uint32) *big.Int {
 			return big.NewInt(0).Set(rewardsTopUpGradientPoint)
 		},
-		RewardsTopUpFactorInEpochCalled: func(epoch uint32) float64 {
+		RewardsTopUpFactorInEpochCalled: func(_ uint32) float64 {
 			return topUpRewardFactor
 		},
 	}
@@ -1787,10 +1787,10 @@ func getRewardsCreatorV35Arguments() RewardsCreatorArgsV2 {
 	topUpRewardFactor := 0.5
 
 	rewardsHandler := &economicsmocks.EconomicsHandlerMock{
-		RewardsTopUpGradientPointInEpochCalled: func(epoch uint32) *big.Int {
+		RewardsTopUpGradientPointInEpochCalled: func(_ uint32) *big.Int {
 			return big.NewInt(0).Set(rewardsTopUpGradientPoint)
 		},
-		RewardsTopUpFactorInEpochCalled: func(epoch uint32) float64 {
+		RewardsTopUpFactorInEpochCalled: func(_ uint32) float64 {
 			return topUpRewardFactor
 		},
 	}