Merge pull request #212 from mundipagg/feature-PAA-228-allow-24-insta…

…llments [Feature] Allow 24 installments
mundipagg · Mar 1, 2021 · 76b1a11 · 76b1a11
2 parents 58cff37 + 197f748
commit 76b1a11
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/Kernel/ValueObjects/Installment.php b/src/Kernel/ValueObjects/Installment.php
@@ -48,9 +48,9 @@ public function __construct($times, $baseTotal, $interest)
     private function setTimes($times)
     {
         $newTimes = intval($times);
-        if ($newTimes < 1 || $newTimes > 12) {
+        if ($newTimes < 1 || $newTimes > 24) {
             throw new InvalidParamException(
-                "A installment times should be set between 1 and 12!",
+                "A installment times should be set between 1 and 24!",
                 $times
             );
         }

diff --git a/tests/Kernel/ValueObjects/InstallmentTest.php b/tests/Kernel/ValueObjects/InstallmentTest.php
@@ -62,9 +62,9 @@ public function aInstallmentShouldBeJsonSerializable()
      * @uses \Mundipagg\Core\Kernel\ValueObjects\Installment
      * @uses \Mundipagg\Core\Kernel\Exceptions\InvalidParamException
      */
-    public function installmentTimesShouldBeBetween1And12()
+    public function installmentTimesShouldBeBetween1And24()
     {
-        for ($times = 1; $times <= 12; $times++) {
+        for ($times = 1; $times <= 24; $times++) {
             $installment = new Installment(
                 $times,
                 1,
@@ -79,7 +79,7 @@ public function installmentTimesShouldBeBetween1And12()
         for($try = 0; $try < $tries; $try++) {
             try {
                 $installment = new Installment(
-                    rand(13, 100000),
+                    rand(25, 100),
                     1,
                     0
                 );