Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gunicorn_memory_status hides some error behind another one. #1075

Open
Gu1nness opened this issue Apr 26, 2020 · 3 comments
Open

gunicorn_memory_status hides some error behind another one. #1075

Gu1nness opened this issue Apr 26, 2020 · 3 comments
Labels
no-issue-activity

Comments

@Gu1nness
Copy link

When the plugin cannot find the Master PID file, it raises an error here, which is catched here and prints an error Couldn't retrieve gunicorn memory usage information while it should print Couldn't read gunicorn pid information.

I can write a fix for this small bug if you want.
@sumpfralle
Copy link
Collaborator

Thank you for your bug report and your detailed explanation!

I can write a fix for this small bug if you want.

That would be great.

While you are at it: maybe you would like to port the plugin(s) to Python3, fix the flake8 issues and maybe even get rid of the bare excepts? :)

Please pick your favorite set of improvements, that you would like to spread over these plugins. Your contribution is very welcome!

@Gu1nness
Copy link
Author

Gu1nness commented Apr 28, 2020 •
edited
Loading

Ok, I'll do all of this happily!

@github-actions
Copy link

Stale issue message

@steveschnepp steveschnepp reopened this Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
no-issue-activity
Milestone
No milestone
Development

No branches or pull requests
3 participants
@steveschnepp @sumpfralle @Gu1nness