Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate plugins with duplicate names within one source repository #5

Open
sumpfralle opened this issue Oct 5, 2020 · 2 comments
Open

Comments

@sumpfralle
Copy link
Contributor

Some plugins in the munin repository have the same name:

$ find plugins/ -name cpu.in
plugins/node.d.netbsd/cpu.in
plugins/node.d.linux/cpu.in
plugins/node.d.freebsd/cpu.in
plugins/node.d.sunos/cpu.in
plugins/node.d.aix/cpu.in

Only one of these plugins (maybe even a random one) is the final plugin to be presented in the plugin gallery.

Instead the generator should detect duplicate names and try to add a unique token based on the distinct part of the filename's path (e.g. cpu (linux) or linux/cpu).

@steveschnepp
Copy link
Member

I don't really mind decimating the plugins by names, regardless of where there are. But we should simply point to the various implementations, while keeping the page unique.

Also, we could move towards name "unification". Meaning that if a plugin has the same name, we expect it to have the same output, or something very similar. At least visually.

Which isn't solved by the gallery, but gallery will help unification, as it offers a aggregated view

@sumpfralle
Copy link
Contributor Author

I don't really mind decimating the plugins by names, regardless of where there are. But we should simply point to the various implementations, while keeping the page unique.

Since the main content of each plugin page is its documentation and the plugin code (both will vary inevitably), I cannot really imagine a fair/generic approach for merging these into one.

But maybe providing a list of alternatives (plugins with the same name) right at the top of each plugin page could be a good approach to solve this? This could also work nicely for plugins targeted at different versions of the service being monitored (e.g. asterisk_14 and asterisk_18). I think, this could be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants