kill squeezelite when closing the app #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change modifies the code to keep track of the squeezelite process and to kill it when the app is closed. The SqueezeLite struct makes it possible to expand this functionality in the future to do other things such as restarting the squeezelite process or implement multiple squeezelite instances. This change has been tested on Linux.
|
Awesome thanks a lot! This was much needed. Will test on the different platforms and merge. Might have to wait a day or so as I'm pretty busy at the moment, but I'll try to review and release as quickly as possible 👍 |
|
Thanks you for your help! |
|
Sure, I'll send some other PRs in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies the code to keep track of the squeezelite process and to kill it when the app is closed.
The SqueezeLite struct makes it possible to expand this functionality in the future to do other things such as restarting the squeezelite process or implement multiple squeezelite instances.
This change has been tested on Linux.
Fixes #41