oid generator technically incorrect because not enough digits.

Author: arscan

lib/resource_generator.rb

@@ -156,9 +156,10 @@ def self.generate_child(type, namespace, embedded=0)
       end
 
       def self.random_oid
+        #	Regex: urn:oid:[0-2](\.[1-9]\d*)+ (http://hl7.org/fhir/STU3/datatypes.html#oid)
         oid = "urn:oid:2"
-        SecureRandom.random_number(12).times do |i|
-          oid = "#{oid}.#{SecureRandom.random_number(500)}"
+        rand(1..12).times do
+          oid = "#{oid}.#{rand(1..500)}"
         end
         oid
       end

test/unit/resource_generator_test.rb

@@ -46,4 +46,11 @@ def check_valid_namespaces(resource, namespace)
     return resource.instance_values.values.all? { |v| check_valid_namespaces(v, namespace) }
   end
 
+  def test_valid_oid_generator
+    500.times do
+      random_oid = Crucible::Tests::ResourceGenerator.random_oid
+      assert /urn:oid:[0-2](\.[1-9]\d*)+/.match?(random_oid), "Randomly generated #{random_oid} does not appear to be a valid oid."
+    end
+  end
+
 end