Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

general impressions of v3 #15

Open
maglott opened this issue Oct 28, 2022 · 8 comments
Open

general impressions of v3 #15

maglott opened this issue Oct 28, 2022 · 8 comments
Labels
enhancement New feature or request

Comments

@maglott
Copy link

maglott commented Oct 28, 2022

predicted protein descriptions: compare the predicted protein descriptions for https://v2.mutalyzer.nl/name-checker?description=%09NM_001204398.1%3Ac.268_288dup and https://mutalyzer.nl/normalizer/%09NM_001204398.1:c.268_288dup.
I find the former much easier to use to evaluate what has changed.

response time The response time for v2 is much better for simple normalizations. Is it possible to wait to compute the data necessary to support the new features until they are requested?

variant sequence overview My personal preference is the compact display in v2. I prefer to scroll as little as possible.

That said, I appreciate the new features

@erikzmuda
Copy link

Came here to provide feedback on the v3 UI. Strongly dislike the update. The query response should show the info you're after without having to expand all of the sub tabs. It is way less efficient to use now. Really wish there was a way to control the version being used b/c v3 is a huge step in the wrong direction from user perspective.

@jfjlaros
Copy link
Member

jfjlaros commented Oct 28, 2022

The response time for v2 is much better for simple normalizations.

This has two main reasons.

  1. Mutalyzer 3 uses the Description Extractor to normalise variant descriptions. This allows for the normalisation of allele descriptions, e.g., NG_012337.3(NM_003002.4):c.1_10delinsTGGCGGTT is normalised to NG_012337.3(NM_003002.4):c.[1del;10del]. We can now guarantee that whenever two variant descriptions result in the same sequence (after applying them to the same reference sequence), they will result in the same normalised description. Unfortunately, this added correctness comes with a performance penalty.
  2. Mutalyzer 3 currently has a very rudimentary caching system. This is being worked on.

We will take your comments about the visualisations into account in our discussions about the interface.

@jfjlaros
Copy link
Member

Really wish there was a way to control the version being used

Mutalyzer 2 is still online, but perhaps you can help us improve the new interface instead.

For example, would you be helped if we added a configuration option that allows the user to store some preferences about which folds should be open by default?

Your suggestions are welcome.

@maglott
Copy link
Author

maglott commented Oct 28, 2022

I would welcome options to control (1) what is shown (open) by default and (2) the order of presentation. I am accustomed to checking not only the HGVS expression but the display of the reference/alternate sequence that expression represents, and so am still using v2 for simple deletions, insertions, and SNV. In v2 these appear without clicks and scrolling.
I personally use NCBI's graphic sequence displays to view the location of variants across all RefSeqs and am less likely to use the tool to display those mappings.

@jfjlaros jfjlaros added the enhancement New feature or request label Oct 29, 2022
@erikzmuda
Copy link

erikzmuda commented Nov 11, 2022 via email

@jfjlaros
Copy link
Member

Thank you and your group for the detailed feedback. Please allow me to give some background information and motivation before proceeding to a discussion about possible improvements.


The interface of the Position Converter was changed intentionally because the former interface gives people the impression that HGVS descriptions are mapped or lifted over from one reference sequence to an other, while in reality only the positions were converted. This resulted in:

  • Invalid descriptions being converted to other invalid descriptions.
  • Correct descriptions being converted to wrong or invalid descriptions (notably conversions to and from transcripts residing on the negative strand were problematic).

We have always recommended to use the Name Checker on the output of the Position Converter, but this advice was rarely followed. For more information and examples, please see issue #14.

In Mutalyzer 3 we aim to have the functionality of both the Mutalyzer 2 Name Checker as well as the Mutalyzer 2 Position Converter integrated in the Normalizer.


From your feedback I think we can extract three technical questions:

1. Can we provide a workflow that is similar to the Mutalyzer 2 Position Converter workflow, but without all of its flaws?
2. Can we improve the responsiveness of Mutalyzer 3?
3. Can we improve the layout of the Normalizer results page?

To address point 1, we could think about allowing a combination of a genome build and a RefSeq identifier as input for the Normalizer. For example:

GRCh37(NM_002001.4):c.10del

Which would be corrected to:

NC_000001.10(NM_002001.4):c.10del

The "converted" descriptions will be available in the "Equivalent Descriptions" fold of the results page.

Point 2 is being worked on as we speak.

To address point 3, I would suggest to open a separate discussion to get more feedback from the community and to share ideas for improvement.

@maglott
Copy link
Author

maglott commented Nov 17, 2022

Thanks for this detailed response. For point 3, was there a summary of use cases used in the design?
My most frequent usages (I am currently going through old papers for OMIM) are to enter an HGVS expression

  • and look at what is now view variants sequence overview to determine if the effect of the change is captured correctly by the HGVS
  • and check for a warning that the variant includes splice sites
  • verify changes in restriction sites

@jfjlaros
Copy link
Member

jfjlaros commented Dec 4, 2022

@erikzmuda

Point 1 has been addressed. You may want to try it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants