Add more typing details #1204
Open
Add more typing details #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dreamsorcerer
commented
Apr 19, 2021
| @@ -4,7 +4,7 @@ | |||
| from urllib.parse import urlparse | |||
|
|
|||
| import requests | |||
| from requests import Response | |||
| from requests import Response as Response | |||
There was a problem hiding this comment.
This allows using the Response type without directly depending on requests (which avoids any issues if the underlying library were ever changed).
Used like:
from zeep.transports import Response
resp: Response = client_with_raw_response.service.Foo()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just adding in a couple more annotations.
FYI, it's rather verbose using
typing.*, common practice is to usefrom typing import ....Fixes #1203.