Flush writes to the logfile before calling the subprocess

matyasselmeci · matyasselmeci · commit b74a9742ced4 · 2020-02-27T10:07:43.000-06:00
This should avoid out-of-order output
diff --git a/scripts/update-all-remote-wn-clients b/scripts/update-all-remote-wn-clients
@@ -75,6 +75,7 @@ def call_updater(cfg, section, updater_script, log_dir, dry_run=False):
             b"Started at %s\nUser: %s\nCommand: %r\n\n"
             % (datetime.datetime.now(), local_user, cmd)
         )
+        log_file.flush()
         proc = Popen(
             ["sudo", "-H", "-u", local_user] + cmd,
             stdout=log_file,

Original file line number	Diff line number	Diff line change
`@@ -75,6 +75,7 @@ def call_updater(cfg, section, updater_script, log_dir, dry_run=False):`
`75`	`75`	`b"Started at %s\nUser: %s\nCommand: %r\n\n"`
`76`	`76`	`% (datetime.datetime.now(), local_user, cmd)`
`77`	`77`	`)`
	`78`	`+ log_file.flush()`
`78`	`79`	`proc = Popen(`
`79`	`80`	`["sudo", "-H", "-u", local_user] + cmd,`
`80`	`81`	`stdout=log_file,`