Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] JVM Arguments Enhancement #598

Open
pega-vanhd1 opened this issue Jul 19, 2024 · 4 comments
Open

[Feature Request] JVM Arguments Enhancement #598

pega-vanhd1 opened this issue Jul 19, 2024 · 4 comments

Comments

@pega-vanhd1
Copy link

pega-vanhd1 commented Jul 19, 2024

We are looking to override the algorithms that are available to use with the JVM arguments (host key, public key, kex, cipher, mac), but the downside of this is that we need to hardcode a full list of algorithms that we want to support. It would be nice if there were separate JVM arguments that we could use to provide a supplementary list of algorithms to be used in addition to the default algorithms. This would allow our code to be much more maintainable and future-proof.

@pega-vanhd1 pega-vanhd1 changed the title [eature Request] JVM Arguments Enhancement [Feature Request] JVM Arguments Enhancement Jul 19, 2024
@mwiede
Copy link
Owner

mwiede commented Jul 19, 2024

@norrisjeremy
Copy link
Contributor

Hi @pega-vanhd1,

You can specify JVM arguments for system properties (in the form of -Djsch.XYZ=..., see our FAQ item here for a list of system property names.

Thanks,
Jeremy

@pega-talba
Copy link

Hi folks!

@mwiede Unfortunately in our situation, we are limited to adjusting environments via JVM properties. We can't alter the running code in the environments that need these changes. Essentially, jsch is included as a library within an application being run in many cloud environments, and we don't always have the ability to alter the application. In some cases we do, and for those situations we can provide additive algorithms as shown here. But we don't have the ability to add algorithms in that same additive way via JVM properties.

@norrisjeremy This is what we are currently doing. The problem is that using those system properties requires us to pass in a full list of all supported algorithms. This works, but now we won't automatically have newer algorithms supported if we updated the version of jsch - we would need to adjust the system properties to include the newer algorithms as well. It's also a much longer JVM argument when including all supported algorithms plus the extra 1-2 we need.

Our hope is that we can add an alternative JVM argument that includes a list of algorithms to accept in addition to the default from jsch, rather than a full list of algorithms.

@norrisjeremy
Copy link
Contributor

Hi folks!

@norrisjeremy This is what we are currently doing. The problem is that using those system properties requires us to pass in a full list of all supported algorithms. This works, but now we won't automatically have newer algorithms supported if we updated the version of jsch - we would need to adjust the system properties to include the newer algorithms as well. It's also a much longer JVM argument when including all supported algorithms plus the extra 1-2 we need.

Our hope is that we can add an alternative JVM argument that includes a list of algorithms to accept in addition to the default from jsch, rather than a full list of algorithms.

It sounds like you could simply solve this problem yourself by adding your own JVM arguments to your own application(s) to adjust the JSch config.
I'm not sure I see much value in further complicating the JSch library to support this.

Thanks,
Jeremy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants