-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VBiasManager parameters are not saved by "Save Settings" #108
Comments
@Chysn <https://github.com/Chysn> (tagging you because of #90
<#90> - thanks for that! ), is there a
hardware limitation preventing the chosen VOR option to be saved to EEPROM?
That would be a shame. Or do the aforementioned save methods (and/or all of
the apps' own save functions; for example,
https://github.com/mxmxmx/O_C/blob/master/software/o_c_REV/APP_ENVGEN.ino#L852-L857 )
still need to be updated? Or maybe SettingsBase.Save in util_settings?
No hardware limitation, but it's a matter of allocating very limited space.
I can't say whether such opportunities still exist in the Ornament and
Crime firmware.
…--Jason
On Wed, Dec 9, 2020 at 10:00 PM W. Winter ***@***.***> wrote:
The VOR option chosen through VBiasManager is not saved by
save_global_settings() or save_app_data(). It must always be re-selected
every time the module is powered up. Apologies if discussing VOR in an
issue here is considered outside the scope of the main O_C repo.
@Chysn <https://github.com/Chysn> (tagging you because of #90
<#90> - thanks for that! ), is there a
hardware limitation preventing the chosen VOR option to be saved to EEPROM?
That would be a shame. Or do the aforementioned save methods (and/or all of
the apps' own save functions; for example,
https://github.com/mxmxmx/O_C/blob/master/software/o_c_REV/APP_ENVGEN.ino#L852-L857
) still need to be updated? Or maybe SettingsBase.Save in util_settings?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#108>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AENMQVHP3VEE4ZG3MWSO2N3SUA2URANCNFSM4UUMITVQ>
.
|
Yeah, space is a bit tight but I think it'd fit somewhere. Shay mentioned wanting it to be saved per app which is a bit more involved (it'd either have to be in all the Right now the VOR stuff is in a bit of limbo. I don't really think it should live in this repo - or rather, I don't think we should be fielding support for it - but AFAIK there's no other plan. There's a few other unsolved issues as well. |
Thanks for clarifying @patrickdowling and @Chysn . I understand that there are a couple of other issues besides storing the VOR settings: VOR breaking autotune, and a ~3mV offset between the calibration interface and normal operation of the DAC. The VOR storage part irks me and I'd like to find someone to help with these issues. I also understand that you'd prefer for further development of the VOR features to not live within the O_C repo. Would it work if Shay forked this repo and further VOR work happened there, or would a more radical break than forking be preferable? |
The incomplete state kind of irks me as well (even if it's not really my circus). To be fair, Shay and I were in touch a while back, but all other issues aside, to fix things the way I'd like them done requires more time investment than I've wanted to divert from other things. |
The VOR option chosen through VBiasManager is not saved by
save_global_settings()
orsave_app_data()
. It must always be re-selected every time the module is powered up. Also, every time you do the Save Settings action, the last-selected VOR setting is immediately forgotten. Apologies if discussing VOR in an issue here is considered outside the scope of the main O_C repo.@Chysn (tagging you because of #90 - thanks for that! ), is there a hardware limitation preventing the chosen VOR option to be saved to EEPROM? That would be a shame. Or do the aforementioned save methods (and/or all of the apps' own save functions; for example, https://github.com/mxmxmx/O_C/blob/master/software/o_c_REV/APP_ENVGEN.ino#L852-L857 ) still need to be updated? Or maybe SettingsBase.Save in util_settings?
The text was updated successfully, but these errors were encountered: