Ensure original options list is not mutated

Author: andyghiuta

.npmrc

@@ -1,2 +1,3 @@
 # install as dev by default
 save-dev = true
+registry=https://registry.npmjs.org

src/components/AdvancedSelect.vue

@@ -377,10 +377,10 @@ export default {
           f.push({
             header: o.label,
           });
-          f.push(...o.options.map(opt => Object.assign(opt, { parentHeader: o.label, selected: this.valueIsSelected(o.value) })));
+          f.push(...o.options.map(opt => Object.assign({}, opt, { parentHeader: o.label, selected: this.valueIsSelected(o.value) })));
         } else {
           // it's an item without group, push it to the list
-          f.push(Object.assign(o, { selected: this.valueIsSelected(o.value) }));
+          f.push(Object.assign({}, o, { selected: this.valueIsSelected(o.value) }));
         }
         return f;
       }, []);
@@ -501,7 +501,7 @@ export default {
     selectAll() {
       // when selecting all, concatenate the exiting selected values
       // with the currently filtered ones
-      this.myValue = [... new Set([].concat(
+      this.myValue = [...new Set([].concat(
         this.myValue || [],
         this.filtered.filter(o => !o.header && !o.disabled).map(o => o.value)
       ))];

tests/unit/AdvancedSelect.spec.js

@@ -145,6 +145,18 @@ describe('AdvancedSelect.vue', () => {
       links.at(1).trigger('click');
       expect(wrapper.vm.myValue).to.equal(2);
     });
+    it('Original options list is not mutated', () => {
+      const options = [{ text: '1', value: 1 }, { text: '2', value: 2 }];
+      const wrapper = shallowMount(Select, {
+        propsData: {
+          options,
+        },
+      });
+      const links = wrapper.findAll('div.btn-group > ul > li > ul > li > a');
+      links.at(0).trigger('click');
+      links.at(1).trigger('click');
+      expect(options).to.deep.eq([{ text: '1', value: 1 }, { text: '2', value: 2 }]);
+    });
     it('Value is set on grouped items', () => {
       const wrapper = shallowMount(Select, {
         propsData: {
@@ -318,7 +330,7 @@ describe('AdvancedSelect.vue', () => {
       });
       expect(wrapper.vm.filtered).to.deep.equal([
         { text: 'Option 1', value: 1, subtext: 'Option 1 subtext', selected: false },
-        { text: 'Option 2', value: 2, selected: false},
+        { text: 'Option 2', value: 2, selected: false },
       ]);
       expect(wrapper.findAll('div.btn-group > ul > li > ul > li > a')).to.have.lengthOf(2);
       wrapper.setData({