Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: News Service #17

Open
sansan88 opened this issue Jul 22, 2022 · 0 comments
Open

feat: News Service #17

sansan88 opened this issue Jul 22, 2022 · 0 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@sansan88
Copy link
Collaborator

The news page has 3 sources (services) to get News Data based on different configurations.

  • team (0:n)
  • club (1:n)
  • association (0:n)

News Page file:
https://github.com/myclubapp/app/blob/feat/2022/src/app/pages/news/news/news.page.ts

current state:

  • each news type is called within a separated method. (generally okay, but could be done better to avoid duplicate entries).
  • a loading spinner is shown while loading data.
  • news entries can be duplicated when updated. (This needs improovment)
  • based on the userdata (Auth Service > GetUser) the list of clubs and the list of teams can be found. (this is OK)

Todo:
these three service calls can be combined with the help of rxjs functions. Important is, that news entries don't get duplicated when edited in the database.

@sansan88 sansan88 added the good first issue Good for newcomers label Jul 22, 2022
@sansan88 sansan88 assigned sansan88 and unassigned sansan88 Jul 22, 2022
@fabianmue fabianmue self-assigned this Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants