Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Analytics disable still tries to load analytics #496

Open
githubcdr opened this issue Mar 11, 2019 · 2 comments
Open

Google Analytics disable still tries to load analytics #496

githubcdr opened this issue Mar 11, 2019 · 2 comments
Assignees
Labels
Milestone

Comments

@githubcdr
Copy link

Hi,

I noticed that I receive timeouts when reloading a page at random, after inspecting this issue I found that this code is still present and active even when disabling Google Analytics in the properties file;

 <script>
      (function(i,s,o,g,r,a,m){i['GoogleAnalyticsObject']=r;i[r]=i[r]||function(){
      (i[r].q=i[r].q||[]).push(arguments)},i[r].l=1*new Date();a=s.createElement(o),
      m=s.getElementsByTagName(o)[0];a.async=1;a.src=g;m.parentNode.insertBefore(a,m)
      })(window,document,'script','https://www.google-analytics.com/analytics.js','ga');
    </script>

Since I block Google analytics in DNS this seems to cause a long page load (5+ seconds), please note that I'm not 100% sure but previous versions did not have this issue.

@jkandasa jkandasa self-assigned this Mar 13, 2019
@jkandasa jkandasa added the bug label Mar 13, 2019
@jkandasa jkandasa added this to the 1.5.0 milestone Mar 13, 2019
@jkandasa
Copy link
Member

@githubcdr can you clear cache on your browser and try again?

@githubcdr
Copy link
Author

Hi, I tried but this does not seem to resolv the issue, it might be related to the load on my docker host, I'll have to investigate.

@jkandasa jkandasa modified the milestones: 1.5.0, 1.0.6 Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants