Skip to content

Commit

Permalink
[skia] disable the dev test (microsoft#33494)
Browse files Browse the repository at this point in the history
* [skia] disable the dev test

* version

* add option

* v db

* revert

* v db

* add patch

* v db
  • Loading branch information
FrankXie05 authored Sep 1, 2023
1 parent 09076d1 commit 632a33a
Show file tree
Hide file tree
Showing 5 changed files with 21 additions and 2 deletions.
13 changes: 13 additions & 0 deletions ports/skia/disable-dev-test.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
diff --git a/BUILD.gn b/BUILD.gn
index 3691123..8682b8e 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -97,7 +97,7 @@ config("skia_private") {
if (is_skia_dev_build && !is_wasm) {
defines += [
"SK_ALLOW_STATIC_GLOBAL_INITIALIZERS=1",
- "GR_TEST_UTILS=1",
+ "GR_TEST_UTILS=0",
]
if (skia_enable_graphite) {
defines += [ "GRAPHITE_TEST_UTILS=1" ]
1 change: 1 addition & 0 deletions ports/skia/portfile.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ vcpkg_from_git(
disable-msvc-env-setup.patch
uwp.patch
core-opengl32.patch
disable-dev-test.patch
)

# these following aren't available in vcpkg
Expand Down
2 changes: 1 addition & 1 deletion ports/skia/vcpkg.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "skia",
"version": "0.36.0",
"port-version": 8,
"port-version": 9,
"description": [
"Skia is an open source 2D graphics library which provides common APIs that work across a variety of hardware and software platforms.",
"It serves as the graphics engine for Google Chrome and Chrome OS, Android, Mozilla Firefox and Firefox OS, and many other products.",
Expand Down
2 changes: 1 addition & 1 deletion versions/baseline.json
Original file line number Diff line number Diff line change
Expand Up @@ -7670,7 +7670,7 @@
},
"skia": {
"baseline": "0.36.0",
"port-version": 8
"port-version": 9
},
"skyr-url": {
"baseline": "1.13.0",
Expand Down
5 changes: 5 additions & 0 deletions versions/s-/skia.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
{
"versions": [
{
"git-tree": "9389efe5ea2540ef9a0885b796d13e0d730fb603",
"version": "0.36.0",
"port-version": 9
},
{
"git-tree": "59bcc7110298012cf8f0d6e68ec8d04a4cb01e8b",
"version": "0.36.0",
Expand Down

0 comments on commit 632a33a

Please sign in to comment.