Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tick in URL not compatible with Tweetdeck #6503

Closed
RichardTaylor opened this issue Sep 1, 2021 · 3 comments
Closed

Tick in URL not compatible with Tweetdeck #6503

RichardTaylor opened this issue Sep 1, 2021 · 3 comments
Labels
f:request-analysis improvement Improves existing functionality (UI tweaks, refactoring, performance, etc) x:uk

Comments

@RichardTaylor
Copy link

Alaveteli sometimes puts the following in the URL for a search result.

utf8=✓

This resulted in Tweetdeck not properly counting the characters used in a tweet including a URL containing the tick.

This may be a bug in Tweetdeck, but perhaps doing unusual things isn't a good idea.

It appears utf8=✓ is added to the URL when a search is conducted from the second search box on a public body page, the search box under "Keywords"

@gbp
Copy link
Member

gbp commented Sep 1, 2021

It isn't something we've added, it comes from Rails. https://github.com/rails/rails/blob/4866154/actionview/lib/action_view/helpers/form_tag_helper.rb#L816-L823. This gives some background as to why http://intertwingly.net/blog/2010/07/29/Rails-and-Snowmen

The issue will be resolved when we #5159 as the new action_controller.default_enforce_utf8 config defaults to false. See: rails/rails#32125

I would say it is a fairly standard thing to do and we won't do anything for this other than upgrading Rails so am going to close this issue.

@gbp gbp closed this as completed Sep 1, 2021
@garethrees garethrees added f:request-analysis improvement Improves existing functionality (UI tweaks, refactoring, performance, etc) x:uk labels Sep 6, 2021
@RichardTaylor
Copy link
Author

I hit this issue again today.

Workarounds include removing the utf8=✓ parameter from the URL or escaping it to utf8=%E2%9C%93

@garethrees
Copy link
Member

Assume we might actually need #5851 since #5159 has already been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
f:request-analysis improvement Improves existing functionality (UI tweaks, refactoring, performance, etc) x:uk
Projects
None yet
Development

No branches or pull requests

3 participants