Fix: no-useless-rest-spread crashed (fixes #17)

mysticatea · mysticatea · commit 30a592820c93 · 2017-10-18T14:32:47.000+09:00
diff --git a/lib/rules/no-useless-rest-spread.js b/lib/rules/no-useless-rest-spread.js
@@ -115,8 +115,9 @@ module.exports = {
             const parentType = node.parent.type
             const argumentType = node.argument.type
             const isArray = argumentType.startsWith("Array")
+            const isObject = !isArray && argumentType.startsWith("Object")
             const isRedundant = (
-                argumentType === parentType ||
+                ((isArray || isObject) && argumentType === parentType) ||
                 (isArray && FUNC_TYPE.test(parentType))
             )
 
diff --git a/tests/lib/rules/no-useless-rest-spread.js b/tests/lib/rules/no-useless-rest-spread.js
@@ -35,6 +35,7 @@ ruleTester.run("no-useless-rest-spread", rule, {
         "foo(...{a}, ...{b})",
         "let list = [...{a}]",
         "let obj = {...[a]}",
+        "f(...g())",
     ],
     invalid: [
         {

Original file line number	Diff line number	Diff line change
`@@ -35,6 +35,7 @@ ruleTester.run("no-useless-rest-spread", rule, {`
`35`	`35`	`"foo(...{a}, ...{b})",`
`36`	`36`	`"let list = [...{a}]",`
`37`	`37`	`"let obj = {...[a]}",`
	`38`	`+ "f(...g())",`
`38`	`39`	`],`
`39`	`40`	`invalid: [`
`40`	`41`	`{`